setting image buffer and queueing resize
I had just fixed the dw simple image test that hadn't requested a resize when setting the imgbuf. And now I just found that one of the scaled2 test's images needs it as well. Perhaps we should make the resize argument to setBuffer() mandatory. But, better yet, how about if Image::setBuffer() just does a queueResize() if either of its dimensions are LENGTH_AUTO?
On Wed, Apr 28, 2010 at 05:21:56PM +0000, corvid wrote:
I had just fixed the dw simple image test that hadn't requested a resize when setting the imgbuf. And now I just found that one of the scaled2 test's images needs it as well.
Perhaps we should make the resize argument to setBuffer() mandatory.
But, better yet, how about if Image::setBuffer() just does a queueResize() if either of its dimensions are LENGTH_AUTO?
I also think we should get rid of the resize parameter of setBuffer() entirely. I'm not 100% sure about when we need the queueResize(), that would need some testing.
On Sun, May 09, 2010 at 07:34:29AM +0200, Johannes Hofmann wrote:
On Wed, Apr 28, 2010 at 05:21:56PM +0000, corvid wrote:
I had just fixed the dw simple image test that hadn't requested a resize when setting the imgbuf. And now I just found that one of the scaled2 test's images needs it as well.
Perhaps we should make the resize argument to setBuffer() mandatory.
But, better yet, how about if Image::setBuffer() just does a queueResize() if either of its dimensions are LENGTH_AUTO?
I also think we should get rid of the resize parameter of setBuffer() entirely. I'm not 100% sure about when we need the queueResize(), that would need some testing.
AFAIR the main idea is to queueResize() whenever a widget changes it size. That way several widgets can make the call and the resize process is done only once when the time arrives. BTW, I'm not oppossed at all in eliminating the resize parameter, but haven't looked at it in enough depth to assign any weight to my opinnion on the subject. ;-) -- Cheers Jorge.-
participants (3)
-
corvid＠lavabit.com -
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de