Re: fullscreen/maximize question
Hi there, Here's a funny thing that I'd like to make some tests on. In ui.cc:888 if you: - #if 0 + #if 1 for me, there's the following problem:
If I start dillo as a small window, then hide the panel (using the old ctrl-find binding), then maximize the window, then unhide the panel with the same trick, I get a control panel slightly higher than what I started with.
this happens to me with GNU/Linux and fltk2-r5975. but... On Sun, Nov 18, 2007 at 01:26:09PM +0000, place wrote:
What FLTK2 version are you using?
fltk-2.0.x-r5941
If I undertood right, this doesn't happen to you.
right.
Does it happen to anyone else? -- Cheers Jorge.-
On Sun, Nov 18, 2007 at 02:11:27PM -0300, Jorge Arellano Cid wrote:
Hi there,
Here's a funny thing that I'd like to make some tests on. In ui.cc:888 if you:
- #if 0 + #if 1
for me, there's the following problem:
If I start dillo as a small window, then hide the panel (using the old ctrl-find binding), then maximize the window, then unhide the panel with the same trick, I get a control panel slightly higher than what I started with.
this happens to me with GNU/Linux and fltk2-r5975.
but...
On Sun, Nov 18, 2007 at 01:26:09PM +0000, place wrote:
What FLTK2 version are you using?
fltk-2.0.x-r5941
If I undertood right, this doesn't happen to you.
right.
Does it happen to anyone else?
Yes, I'm seeing this too. Did not know about this old ctrl-find binding until now. Nice, I really like the fullscreen mode. Johannes
-- Cheers Jorge.-
_______________________________________________ Dillo-dev mailing list Dillo-dev@dillo.org http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
Hi, actually I would propose to use a PackedGroup and let fltk do all the resizing/repositioning. I have attached a patch to dillo2 and dw2 that does this. It's a bit radical, so I think it needs some discussion before it can be applied :-) Cheers, Johannes On Sun, Nov 18, 2007 at 02:11:27PM -0300, Jorge Arellano Cid wrote:
Hi there,
Here's a funny thing that I'd like to make some tests on. In ui.cc:888 if you:
- #if 0 + #if 1
for me, there's the following problem:
If I start dillo as a small window, then hide the panel (using the old ctrl-find binding), then maximize the window, then unhide the panel with the same trick, I get a control panel slightly higher than what I started with.
this happens to me with GNU/Linux and fltk2-r5975.
but...
On Sun, Nov 18, 2007 at 01:26:09PM +0000, place wrote:
What FLTK2 version are you using?
fltk-2.0.x-r5941
If I undertood right, this doesn't happen to you.
right.
Does it happen to anyone else?
-- Cheers Jorge.-
_______________________________________________ Dillo-dev mailing list Dillo-dev@dillo.org http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
Hi, On Sun, Nov 18, 2007 at 10:50:59PM +0100, Johannes Hofmann wrote:
Hi,
actually I would propose to use a PackedGroup and let fltk do all the resizing/repositioning. I have attached a patch to dillo2 and dw2 that does this. It's a bit radical, so I think it needs some discussion before it can be applied :-)
For me this is very good. I remember long ago coding the UI with a less predictable FLTK2; once a way for it to work as desired was found, that was it. If a simpler approach works today, great. It even solves some problems where current scrollbars don't appear. If Sebastian agrees on having them this way, great (maybe there's a need of finer control though, I don't know). Sebastian? -- Cheers Jorge.-
Hi, On Sun, Nov 18, 2007 at 11:37:45PM -0300, Jorge Arellano Cid wrote:
Hi,
On Sun, Nov 18, 2007 at 10:50:59PM +0100, Johannes Hofmann wrote:
Hi,
actually I would propose to use a PackedGroup and let fltk do all the resizing/repositioning. I have attached a patch to dillo2 and dw2 that does this. It's a bit radical, so I think it needs some discussion before it can be applied :-)
For me this is very good. I remember long ago coding the UI with a less predictable FLTK2; once a way for it to work as desired was found, that was it.
If a simpler approach works today, great.
It even solves some problems where current scrollbars don't appear. If Sebastian agrees on having them this way, great (maybe there's a need of finer control though, I don't know).
The problem might be that the scrollbars are currently children of TopGroup and not of FltkViewport. They are created in the FltkViewport constructor but never added to the FltkViewport widget. Instead they get added to TopGroup (accidentally?) because of TopGroup->begin() in void set_render_layout_begin(). Is this intended? If yes, they would need to be replaced too. I really prefer direct calls to add() instead of this begin()/end() stuff. It makes things much clearer. Cheers, Johannes
Sebastian?
-- Cheers Jorge.-
_______________________________________________ Dillo-dev mailing list Dillo-dev@dillo.org http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
Hi, On Sun, Nov 18, Johannes Hofmann wrote:
actually I would propose to use a PackedGroup and let fltk do all the resizing/repositioning. I have attached a patch to dillo2 and dw2 that does this. It's a bit radical, so I think it needs some discussion before it can be applied :-)
As an answer to this and an other mail (Johannes?): hiding scrollbars is actually intended, if they are not used. That is, e.g. a vertical scrollbar should be invisible, when the text is short enough, and this saved space should be used for the text. If the latter is not the case, this is actually a bug. (More on this later.) Sebastian
On Tue, Nov 20, 2007 at 08:11:48PM +0100, Sebastian Geerken wrote:
Hi,
On Sun, Nov 18, Johannes Hofmann wrote:
actually I would propose to use a PackedGroup and let fltk do all the resizing/repositioning. I have attached a patch to dillo2 and dw2 that does this. It's a bit radical, so I think it needs some discussion before it can be applied :-)
As an answer to this and an other mail (Johannes?): hiding scrollbars is actually intended, if they are not used. That is, e.g. a vertical scrollbar should be invisible, when the text is short enough, and this saved space should be used for the text. If the latter is not the case, this is actually a bug.
Yes, the hiding of the scrollbar when it is not needed is a feature. A very useful one :-) However I think view and layout should not care about scrollbars. Attached is a patch (a proof of concept only) that * moves scrollbar creation to ui.cc * uses a PackedGroup for TopGroup and lets this PackedGroup do the layout of Panel, Main, StatusBar _and_ the scrollbars. * a reference to the scrollbars is passed to FltkViewport so that it can adjust their sizes and hide()/show() them as needed. That way view and layout only need to be able to deal with size changes whether they are caused by the user that modifies the window size, or by TopGroup that rearranges things, because a scrollbar becomes visible or gets hidden. This would make all the scrollbar handling in layout unneccessary. But as I do not completely understand the current code for scrollbars in layout, I am probabely missing something... Johannes PS: As a side effect standard fltk replace() can be used again in UI::set_render_layout().
participants (3)
-
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de -
sgeerken＠dillo.org