Jorge wrote:

On Fri, Nov 28, 2008 at 10:08:21PM +0000, corvid wrote:

...

...

Now if I go to:

http://www.dillo.org/bugtrack/Dremove.html

and fill the entries with the keyboard, then TAB to the submit button and press ENTER, nothing happens.

Doing the same, with the unpatched version, works OK here...

Here's one with the widgetCallback stuff changed in fltkui.cc

Middle click submits in new tab was committed!

With this minor changes:

* A compiler warning fix * An event_key() test instead of event_button() because the latter may return garbage. It may be safer.

events.h show both of them returning e_keysym -- although, given the changes you made in fltkui.cc, it does naturally make sense to use event_key.

BTW, now it submits with Enter but not with Space.

Yes, I'd noticed that the buttons were written to make Space submit, which surprised me a bit. Also, I saw that you can hold down Enter and have the key repeat submitsubmitsubmitsubmit.... Perhaps it would be good to change complex button's handle() from KEY to KEYUP (and try to talk the FLTKers into a similar change for Button).