Some more cleaning up of configure.in: Move AC_CANONICAL_SYSTEM We should call AC_CANONICAL_SYSTEM immediately after AC_INIT otherwise autoconf throws a warning "AC_ARG_PROGRAM was called before AC_CANONICAL_TARGET". (This was introduced by my previous configure.in patch, oops!) Remove AM_PROG_CC_STDC AM_PROG_CC_STDC has been folded into AC_PROG_CC . Amusing facts: * This removes 670 lines (~ 9%) from configure! * AM_PROG_CC_STDC is so obsolete it's not even mentioned in the current docs! I Googled an old version[1] to confirm that it's been obsolete since automake 1.8 (released 2003-12-10). After removing this macro, AM_INIT_AUTOMAKE is the only AM_* macro that Dillo uses. Remove AC_HEADER_STDC This isn't actually marked as obsolete but the manual[2] states: This macro is obsolescent, as current systems have conforming header files. New programs need not use this macro. The Dillo source does not use the variable STDC_HEADERS that AC_HEADER_STDC defines. Please comment. Regards, Jeremy Henty [1] http://www.delorie.com/gnu/docs/automake/automake_24.html [2] http://www.gnu.org/software/autoconf/manual/html_node/Particular-Headers.htm...
corvid wrote:
Jeremy wrote:
Some more cleaning up of configure.in:
It all seems reasonable to me -- and works when I run it :)
Looking through configure.in, I remember that Joerg wanted us to update the AC_CHECK_SIZEOF stuff at one point...
TO_DO++ :-) . Any idea what he thought needed doing? Regards, Jeremy Henty
Jeremy wrote:
corvid wrote:
Jeremy wrote:
Some more cleaning up of configure.in:
It all seems reasonable to me -- and works when I run it :)
Looking through configure.in, I remember that Joerg wanted us to update the AC_CHECK_SIZEOF stuff at one point...
TO_DO++ :-) . Any idea what he thought needed doing?
http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-October/005135.html has: Consider to replace the AC_CHECK_SIZEOF() point and d_size.h magic with AC_TYPE_UINT16_T and friends. THose use either the system macros or figure out the rest (just include inttypes.h and sys/types.h if present).
On Sat, Jan 01, 2011 at 11:13:10AM +0000, Jeremy Henty wrote: Bump? I have one upvote from corvid, what do the other devs think? (If nothing else I'd like to fix the "AC_ARG_PROGRAM was called before AC_CANONICAL_TARGET" warning, since it was my fault!) Regards, Jeremy Henty
Some more cleaning up of configure.in:
Move AC_CANONICAL_SYSTEM
We should call AC_CANONICAL_SYSTEM immediately after AC_INIT otherwise autoconf throws a warning "AC_ARG_PROGRAM was called before AC_CANONICAL_TARGET". (This was introduced by my previous configure.in patch, oops!)
Remove AM_PROG_CC_STDC
AM_PROG_CC_STDC has been folded into AC_PROG_CC .
Amusing facts: * This removes 670 lines (~ 9%) from configure! * AM_PROG_CC_STDC is so obsolete it's not even mentioned in the current docs! I Googled an old version[1] to confirm that it's been obsolete since automake 1.8 (released 2003-12-10).
After removing this macro, AM_INIT_AUTOMAKE is the only AM_* macro that Dillo uses.
Remove AC_HEADER_STDC
This isn't actually marked as obsolete but the manual[2] states:
This macro is obsolescent, as current systems have conforming header files. New programs need not use this macro.
The Dillo source does not use the variable STDC_HEADERS that AC_HEADER_STDC defines.
Please comment.
Regards,
Jeremy Henty
[1] http://www.delorie.com/gnu/docs/automake/automake_24.html [2] http://www.gnu.org/software/autoconf/manual/html_node/Particular-Headers.htm...
# HG changeset patch # Parent dc2a158373516a528d7e02fbfb21a5722a21a1ca configure.in: move AC_CANONICAL_SYSTEM to fix an autoconf warning.
diff -r dc2a15837351 -r 676eaaad8f1b configure.in --- a/configure.in Sat Jan 01 09:42:40 2011 +0000 +++ b/configure.in Sat Jan 01 10:39:06 2011 +0000 @@ -1,13 +1,14 @@ dnl Process this file with aclocal, autoconf and automake.
AC_INIT([dillo], [2.2]) + +dnl Detect the canonical host and target build environment +AC_CANONICAL_SYSTEM + AM_INIT_AUTOMAKE AC_CONFIG_SRCDIR([src/dillo.cc]) AC_CONFIG_HEADERS([config.h])
-dnl Detect the canonical host and target build environment -AC_CANONICAL_SYSTEM - sysconfdir=${sysconfdir}/${PACKAGE}
dnl Options
# HG changeset patch # Parent dc17d306c0cd8ebb53cc61ef98f85096d50f0157 configure.in: remove obsolete AM_PROG_CC_STDC.
diff -r dc17d306c0cd -r 5085c1daa875 configure.in --- a/configure.in Thu Dec 30 12:48:30 2010 +0000 +++ b/configure.in Fri Dec 31 08:48:17 2010 +0000 @@ -39,7 +39,6 @@ AC_ARG_ENABLE(rtfl, [ --enable-rtfl Build with rtfl messages]) AC_PROG_CC AC_PROG_CXX -AM_PROG_CC_STDC AC_PROG_RANLIB AC_PROG_CPP
# HG changeset patch # Parent 5085c1daa8755400e84974cd7f8d4dd54f3e005d configure.in: remove obsolescent AC_HEADER_STDC.
diff -r 5085c1daa875 -r 9041562674a8 configure.in --- a/configure.in Fri Dec 31 08:48:17 2010 +0000 +++ b/configure.in Fri Dec 31 09:26:48 2010 +0000 @@ -448,7 +448,6 @@ dnl Checks for header files dnl ----------------------- dnl -AC_HEADER_STDC AC_CHECK_HEADERS(fcntl.h unistd.h sys/uio.h)
dnl --------------------------
_______________________________________________ Dillo-dev mailing list Dillo-dev@dillo.org http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
On Tue, Jan 04, 2011 at 07:01:24PM +0000, Jeremy Henty wrote:
On Sat, Jan 01, 2011 at 11:13:10AM +0000, Jeremy Henty wrote:
Bump? I have one upvote from corvid, what do the other devs think? (If nothing else I'd like to fix the "AC_ARG_PROGRAM was called before AC_CANONICAL_TARGET" warning, since it was my fault!)
When a simple patch doesn't work as expected, there's an excellent excuse for a cleanup around it. ;-) My vote is: go ahead quickly! -- Cheers Jorge.-
On Tue, Jan 04, 2011 at 07:12:34PM -0300, Jorge Arellano Cid wrote:
On Tue, Jan 04, 2011 at 07:01:24PM +0000, Jeremy Henty wrote:
On Sat, Jan 01, 2011 at 11:13:10AM +0000, Jeremy Henty wrote:
Bump? I have one upvote from corvid, what do the other devs think? (If nothing else I'd like to fix the "AC_ARG_PROGRAM was called before AC_CANONICAL_TARGET" warning, since it was my fault!)
When a simple patch doesn't work as expected, there's an excellent excuse for a cleanup around it. ;-)
My vote is: go ahead quickly!
OK, done! Regards, Jeremy Henty
On Wed, Jan 05, 2011 at 08:24:58AM +0000, Jeremy Henty wrote:
On Tue, Jan 04, 2011 at 07:12:34PM -0300, Jorge Arellano Cid wrote:
On Tue, Jan 04, 2011 at 07:01:24PM +0000, Jeremy Henty wrote:
On Sat, Jan 01, 2011 at 11:13:10AM +0000, Jeremy Henty wrote:
Bump? I have one upvote from corvid, what do the other devs think? (If nothing else I'd like to fix the "AC_ARG_PROGRAM was called before AC_CANONICAL_TARGET" warning, since it was my fault!)
When a simple patch doesn't work as expected, there's an excellent excuse for a cleanup around it. ;-)
My vote is: go ahead quickly!
OK, done!
It works for me. Now let's see what the list says. -- Cheers Jorge.-
participants (3)
-
corvid＠lavabit.com -
jcid＠dillo.org -
onepoint＠starurchin.org