Should zlib be required? I notice that testing for zlib is currently just a part of deciding whether to enable png. I either need to make configure.in require it, or make zlib optional with some ifdefs. As for which, though, I don't have much of an opinion.
Joerg wrote:
On Sat, May 10, 2008 at 12:17:37PM +0000, corvid wrote:
Should zlib be required?
Given many sites allow compression for HTML pages, it is useful to have around anyway. I would just make it a requirement.
Attached. I'm not sure that the old_libs code is serving any purpose, but, being an autoconf newbie, I left it alone.
On Mon, May 12, 2008 at 10:24:19PM +0000, corvid wrote:
Joerg wrote:
On Sat, May 10, 2008 at 12:17:37PM +0000, corvid wrote:
Should zlib be required?
Given many sites allow compression for HTML pages, it is useful to have around anyway. I would just make it a requirement.
Attached. I'm not sure that the old_libs code is serving any purpose, but, being an autoconf newbie, I left it alone.
Autoconf is a complex dragon! old_libs was for not stuffing libz in LIBS when the test failed. That way it could continue without zlib and without png. Now, IMHO it looks orthogonal and clean to leave it there. Committed. (now let's pray for it to work everywhere... :-) -- Cheers Jorge.-
* corvid <corvid@lavabit.com> schrieb:
Should zlib be required?
I notice that testing for zlib is currently just a part of deciding whether to enable png. I either need to make configure.in require it, or make zlib optional with some ifdefs.
libpng's zlib-dependency is not Dillo's business. So you should fix configure.in to properly call pkg-config (this was the first thing I did in my branch) If Dillo requires zlib by itself, it should import it propery (eg. via pkg-config). cu -- --------------------------------------------------------------------- Enrico Weigelt == metux IT service - http://www.metux.de/ --------------------------------------------------------------------- Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ ---------------------------------------------------------------------
* Joerg Sonnenberger <joerg.sonnenberger@web.de> schrieb:
On Sat, Jun 07, 2008 at 09:33:51PM +0200, Enrico Weigelt wrote:
If Dillo requires zlib by itself, it should import it propery (eg. via pkg-config).
...and since when does zlib provide any pkg-config glue?
The OSS-QM branch does for quite a long time, and uptream has signalled to include my patch. cu -- --------------------------------------------------------------------- Enrico Weigelt == metux IT service - http://www.metux.de/ --------------------------------------------------------------------- Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ ---------------------------------------------------------------------
participants (4)
-
corvid＠lavabit.com -
jcid＠dillo.org -
joerg.sonnenberger＠web.de -
weigelt＠metux.de