[Patch]: [v2]: fix URL leak in Html_tag_open_link()
OK, I'm fairly sure this version is not as utterly broken as the previous one. :-) BTW, does a_Html_tag_open_link() really need to check the stylesheets preference twice? Jeremy Henty
On Sun, Feb 01, 2009 at 08:32:14AM +0000, Jeremy Henty wrote:
OK, I'm fairly sure this version is not as utterly broken as the previous one. :-)
Committed (with just a small change)
BTW, does a_Html_tag_open_link() really need to check the stylesheets preference twice?
The repush scheme include parsing the HTML header twice. (not a big deal). -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________
On Sun, Feb 01, 2009 at 02:18:10PM -0300, Jorge Arellano Cid wrote:
On Sun, Feb 01, 2009 at 08:32:14AM +0000, Jeremy Henty wrote:
OK, I'm fairly sure this version is not as utterly broken as the previous one. :-)
Committed (with just a small change)
BTW, does a_Html_tag_open_link() really need to check the stylesheets preference twice?
The repush scheme include parsing the HTML header twice. (not a big deal).
I think Jeremy is referring to if (!prefs.load_stylesheets) return; in Html_tag_open_link() which seems redundant, as there is /* Remote stylesheets enabled? */ dReturn_if_fail (prefs.load_stylesheets); some lines above. Cheers, Johannes
On Sun, Feb 01, 2009 at 07:15:43PM +0100, Hofmann Johannes wrote:
On Sun, Feb 01, 2009 at 02:18:10PM -0300, Jorge Arellano Cid wrote:
On Sun, Feb 01, 2009 at 08:32:14AM +0000, Jeremy Henty wrote:
OK, I'm fairly sure this version is not as utterly broken as the previous one. :-)
Committed (with just a small change)
BTW, does a_Html_tag_open_link() really need to check the stylesheets preference twice?
The repush scheme include parsing the HTML header twice. (not a big deal).
I think Jeremy is referring to
if (!prefs.load_stylesheets) return;
in Html_tag_open_link() which seems redundant, as there is
/* Remote stylesheets enabled? */ dReturn_if_fail (prefs.load_stylesheets);
some lines above.
Oh, Yes! Committed. -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________
participants (3)
-
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de -
onepoint＠starurchin.org