segfault in Html_submit_form2()
Hi, after updating to latest CVS, I got the following segfault when submitting a simple form: Program terminated with signal 11, Segmentation fault. #0 0x0805de09 in a_Html_form_event_handler (data=0x28794400, form_receiver=0x28835620, v_resource=0x28841000) at html.cc:4006 4006 input->name, val->str); (gdb) bt #0 0x0805de09 in a_Html_form_event_handler (data=0x28794400, form_receiver=0x28835620, v_resource=0x28841000) at html.cc:4006 #1 0x0805b301 in form::Form::activate (this=0x28835620, resource=0x28841000) at form.cc:100 #2 0x0808e6f7 in dw::core::ui::Resource::ActivateEmitter::emitToReceiver ( this=0x28841008, receiver=0x28835628, signalNo=0, argc=2, argv=0xbfbff15c) at ui.cc:101 #3 0x08093886 in loutsignal::Emitter::emitVoid (this=0x28841008, signalNo=0, argc=2, argv=0xbfbff15c) at signal.cc:81 #4 0x0808e727 in dw::core::ui::Resource::ActivateEmitter::emitActivate (this=0x28841008, resource=0x28841000) at ui.cc:109 #5 0x080aa945 in fltk::Input::handle_key () #6 0x080aadde in fltk::Input::handle () #7 0x080ab0d4 in fltk::Input::handle () #8 0x080ceddb in fltk::Widget::send () #9 0x080b67e4 in fltk::handle () #10 0x080b9bfb in fltk::handle () #11 0x080bb16b in do_queued_events () #12 0x080bb3ad in fltk::wait () #13 0x080bb55d in fltk::run () I think the problem is, that boundary only gets initialized if form->enc == DILLO_HTML_ENC_MULTIPART. Cheers, Johannes
Hi Johannes, On Mon, Mar 03, 2008 at 05:16:51PM +0100, Johannes Hofmann wrote:
Hi,
after updating to latest CVS, I got the following segfault when submitting a simple form:
[...] I think the problem is, that boundary only gets initialized if form->enc == DILLO_HTML_ENC_MULTIPART.
It doesn't segfault for me. Anyway I committed a small fix. Please test and post the URL that was triggering the bug. TIA. -- Cheers Jorge.-
Hi Jorge, On Mon, Mar 03, 2008 at 02:04:25PM -0300, Jorge Arellano Cid wrote:
Hi Johannes,
On Mon, Mar 03, 2008 at 05:16:51PM +0100, Johannes Hofmann wrote:
Hi,
after updating to latest CVS, I got the following segfault when submitting a simple form:
[...] I think the problem is, that boundary only gets initialized if form->enc == DILLO_HTML_ENC_MULTIPART.
It doesn't segfault for me. Anyway I committed a small fix. Please test and post the URL that was triggering the bug.
Yes, that fixes it. It was crashing on every form submit I tried (e.g. www.google.com). I also got a compiler warning: html.cc:3945: warning: 'boundary' may be used uninitialized in this function Cheers, Johannes
TIA.
-- Cheers Jorge.-
_______________________________________________ Dillo-dev mailing list Dillo-dev@dillo.org http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
Johannes wrote:
It was crashing on every form submit I tried (e.g. www.google.com).
Hmm. Too bad I'm still on old Linux. (I looked at DragonflyBSD some months ago, by the way, and was disappointed that I couldn't install from a file on the hard drive. I don't even have a CD writer.)
I also got a compiler warning:
html.cc:3945: warning: 'boundary' may be used uninitialized in this function
I wasn't getting a warning, but this brings up something I've been meaning to ask: Jorge, what do you think of -Werror? So far as I can recall, the only warning on the dillo2/ side currently is Html_input_image. It would save me the trouble of monitoring compilation...
On Mon, Mar 03, 2008 at 05:48:47PM +0000, place wrote:
Johannes wrote:
It was crashing on every form submit I tried (e.g. www.google.com).
Hmm. Too bad I'm still on old Linux. (I looked at DragonflyBSD some months ago, by the way, and was disappointed that I couldn't install from a file on the hard drive. I don't even have a CD writer.)
I also got a compiler warning:
html.cc:3945: warning: 'boundary' may be used uninitialized in this function
I wasn't getting a warning, but this brings up something I've been meaning to ask: Jorge, what do you think of -Werror? So far as I can recall, the only warning on the dillo2/ side currently is Html_input_image. It would save me the trouble of monitoring compilation...
I use: make|grep : quite handy! -- Cheers Jorge.-
On Mon, Mar 03, 2008 at 06:14:29PM +0100, Johannes Hofmann wrote:
Hi Jorge,
On Mon, Mar 03, 2008 at 02:04:25PM -0300, Jorge Arellano Cid wrote:
Hi Johannes,
On Mon, Mar 03, 2008 at 05:16:51PM +0100, Johannes Hofmann wrote:
Hi,
after updating to latest CVS, I got the following segfault when submitting a simple form:
[...] I think the problem is, that boundary only gets initialized if form->enc == DILLO_HTML_ENC_MULTIPART.
It doesn't segfault for me. Anyway I committed a small fix. Please test and post the URL that was triggering the bug.
Yes, that fixes it.
Good!
It was crashing on every form submit I tried (e.g. www.google.com). I also got a compiler warning:
html.cc:3945: warning: 'boundary' may be used uninitialized in this function
Funny how it worked OK here for google, linuxpackages and our bug track engine. Even more, I don't get a compiler warning with: gcc version 4.1.2 20061115 (prerelease) (Debian 4.1.1-21) -- Cheers Jorge.-
after updating to latest CVS, I got the following segfault when submitting a simple form:
Oops! Thanks, Johannes. Patch attached. I had the code doing the right thing at some point in the past after it crashed once on me, but then I forgot why I'd made the change and undid it :( What was the URL?
Hi, On Mon, Mar 03, 2008 at 05:28:36PM +0000, place wrote:
after updating to latest CVS, I got the following segfault when submitting a simple form:
Oops! Thanks, Johannes. Patch attached. I had the code doing the right thing at some point in the past after it crashed once on me, but then I forgot why I'd made the change and undid it :(
FWIW, this patch changes the API of Html_append_input: - Html_append_input(DilloHtmlEnc encoding, const char *boundary, Dstr *url, + Html_append_input(DilloHtmlEnc encoding, Dstr *boundary, Dstr *url, Current CVS has a different patch that fixes the segfault. The question is, do you want me to commit the API change too? -- Cheers Jorge.-
participants (3)
-
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de -
place＠gobigwest.com