dillo crashed on a form where an option didn't have a value (clicked on the Go button at the bottom of http://www.syllable-hardware.info/hardware.php?list.1 ) A glance at the spec suggested that what I wanted in that case was the contents of the tag. So... Trying the change below at least makes it not crash, but I don't know the code, so I'm not calling this a patch. diff -pur dillo2/src/html.cc dillo2-cur/src/html.cc --- dillo2/src/html.cc 2008-01-02 20:20:31.000000000 +0000 +++ dillo2-cur/src/html.cc 2008-01-08 01:30:08.000000000 +0000 @@ -3808,7 +3808,8 @@ static void Html_submit_form2(DilloHtml if (sel_res->isSelected(i)) { DilloHtmlOption *option = input->select->options->get (i); - Html_append_input(DataStr, input->name, option->value); + char *val = option->value ? option->value : option->content; + Html_append_input(DataStr, input->name, val); } } break;
Jorge, please commit place's patch. I tried other fixes but I think that this is the correct and most simple way to do it. Regards, Jeremy Henty
participants (3)
-
jcid@dillo.org
-
onepoint@starurchin.org
-
place@gobigwest.com