Hi Jorge, On Fri, Dec 19, 2008 at 03:37:28PM -0300, Jorge Arellano Cid wrote:
Hi Johannes,
The attached patch does better than the current way, it has more consistency betweeen what's shown the first time and after back and forward (at least with my test set).
Please test it and apply to the css-proto tree.
Thanks! Pushed to css-prototpe.
I don't know what's to be done when multiple stylesheets are specified, like in this site: http://www.lacuarta.cl. Are they all supposed to be loaded? If that's the case, I'd like to load them all and after that, make a single repush instead of one per arrival.
Yes, all stylesheets with a matching media type have to be loaded. I noticed a regression on http://src.opensolaris.org/source/ Maybe it's because now only one stylesheet is loaded? I agree that having just a single repush is probabely better. I don't yet fully understand the new logic and the difference to corvid's approach. Are the style changes in css.cc and css.hh intentional? Generally it would be good to keep whitespace only changes in separate commits. That simplifies reviewing and the search for faulty changesets. BTW. "hg bisect" is a fanatastic tool for that! (similar stuff exists for git too of course).
If that scheme is implemented, then it'd be simple to extend the code to parse this case:
<style type="text/css" media="all"> @import url('/style.css'); </style>
BTW, it's a very nice feeling to see CSS working.
Yes it's fun! Cheers, Johannes
On Fri, Dec 19, 2008 at 09:57:44PM +0100, Johannes Hofmann wrote:
Hi Jorge,
On Fri, Dec 19, 2008 at 03:37:28PM -0300, Jorge Arellano Cid wrote:
Hi Johannes,
The attached patch does better than the current way, it has more consistency betweeen what's shown the first time and after back and forward (at least with my test set).
Please test it and apply to the css-proto tree.
Thanks! Pushed to css-prototpe.
Good!
I don't know what's to be done when multiple stylesheets are specified, like in this site: http://www.lacuarta.cl. Are they all supposed to be loaded? If that's the case, I'd like to load them all and after that, make a single repush instead of one per arrival.
Yes, all stylesheets with a matching media type have to be loaded. I noticed a regression on http://src.opensolaris.org/source/ Maybe it's because now only one stylesheet is loaded?
I agree that having just a single repush is probabely better.
OK. I'll work on it.
I don't yet fully understand the new logic and the difference to corvid's approach.
It's quite messy by now, don't try to find coherence in it! I just tried to push it quick because it may help debug CSS.
Are the style changes in css.cc and css.hh intentional?
Yes.
Generally it would be good to keep whitespace only changes in separate commits. That simplifies reviewing and the search for faulty changesets. BTW. "hg bisect" is a fanatastic tool for that! (similar stuff exists for git too of course).
Sorry, I'm still a newbie with Hg. Yesterday I tried to make that and ended with several heads, and had to resort to plain patches, and erasing the local repo. -- Cheers Jorge.-
participants (2)
-
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de