Jorge, Skip that last patch I sent you, here is a new one which also touches html.c... Please apply ASAP... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ] diff -pruN dillo/src/html.c dillo_patched/src/html.c --- dillo/src/html.c 2003-11-11 21:45:01.947370344 +0100 +++ dillo_patched/src/html.c 2003-11-12 09:01:46.119597904 +0100 @@ -152,7 +152,7 @@ static DilloUrl *Html_url_new(DilloHtml url_str, (use_base_url) ? base_url : URL_STR_(html->linkblock->base_url), flags, pos); - if ((n_ic = URL_ILLEGAL_CHARS(url)) != 0) + if ((n_ic = URL_ILLEGAL_CHARS_(url)) != 0) MSG_HTML("URL has %d illegal character%s (00-1F, 7F or space)\n", n_ic, (n_ic) > 1 ? "s" : ""); return url; diff -pruN dillo/src/url.h dillo_patched/src/url.h --- dillo/src/url.h 2003-11-11 21:45:02.153339032 +0100 +++ dillo_patched/src/url.h 2003-11-12 08:16:28.038808992 +0100 @@ -57,7 +57,7 @@ #define URL_ALT_(u) u->alt #define URL_POS_(u) u->scrolling_position #define URL_STR_(u) a_Url_str(u) -#define URL_ILLEGAL_CHARS(u) url->illegal_chars +#define URL_ILLEGAL_CHARS_(u) url->illegal_chars /* * Access methods that always return a string: @@ -77,7 +77,7 @@ #define URL_ALT(u) NPTR2STR(URL_ALT_(u)) #define URL_POS(u) URL_POS_(u) #define URL_STR(u) NPTR2STR(URL_STR_(u)) - +#define URL_ILLEGAL_CHARS(u) NPTR2STR(URL_ILLEGAL_CHARS_(u)) /* URL-camp compare methods */
On Wed, 12 Nov 2003, Frank de Lange wrote:
Jorge,
Skip that last patch I sent you, here is a new one which also touches html.c... Please apply ASAP...
Oh!, I'll skip this one too. Actually, there's no BUG in the current code (but in the comments). Fixed now. BTW, +#define URL_ILLEGAL_CHARS(u) NPTR2STR(URL_ILLEGAL_CHARS_(u)) is a bug. Jorge.-
Jorge Arellano Cid wrote:
On Wed, 12 Nov 2003, Frank de Lange wrote:
Jorge,
Skip that last patch I sent you, here is a new one which also touches html.c... Please apply ASAP...
Oh!, I'll skip this one too.
Actually, there's no BUG in the current code (but in the comments). Fixed now.
BTW,
+#define URL_ILLEGAL_CHARS(u) NPTR2STR(URL_ILLEGAL_CHARS_(u))
is a bug.
OK, that NPTR2STR is clearly a bug, but so was the absence of URL_ILLEGAL_CHARS_(u). Or call it a style fault if you want, whatever. I see it is fixed now. Thanks... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]
participants (2)
-
Frank de Lange
-
Jorge Arellano Cid