[patch]: use $(srcdir) in Make rules
I was revising the autoconf docs and noticed that make rules should prefix all sources with $(srcdir) to support separate builds[1]. We don't do this, so here's a patch. (Patch generated with Mercurial Queues, BTW.) Jeremy Henty [1]: (autoconf.info)Installation Directory Variables
On Wed, Dec 17, 2008 at 06:40:24PM +0000, Jeremy Henty wrote:
I was revising the autoconf docs and noticed that make rules should prefix all sources with $(srcdir) to support separate builds[1]. We don't do this, so here's a patch.
Commited! (to http://freehg.org/u/dillo/main) @Jorge: I hope that's ok for you.
(Patch generated with Mercurial Queues, BTW.)
Cool. As a result your name shows up properly in the history ;-) Cheers, Johannes
On Fri, Dec 19, 2008 at 06:55:07PM +0100, Johannes Hofmann wrote:
On Wed, Dec 17, 2008 at 06:40:24PM +0000, Jeremy Henty wrote:
I was revising the autoconf docs and noticed that make rules should prefix all sources with $(srcdir) to support separate builds[1]. We don't do this, so here's a patch.
Commited! (to http://freehg.org/u/dillo/main) @Jorge: I hope that's ok for you.
No problem, I'll commit it too. -- Cheers Jorge.-
On Fri, Dec 19, 2008 at 06:55:07PM +0100, Johannes Hofmann wrote:
On Wed, Dec 17, 2008 at 06:40:24PM +0000, Jeremy Henty wrote:
I was revising the autoconf docs and noticed that make rules should prefix all sources with $(srcdir) to support separate builds[1]. We don't do this, so here's a patch.
Commited! (to http://freehg.org/u/dillo/main) @Jorge: I hope that's ok for you.
Oh, sorry, I thought it was to css-prototype. It was main dillo. No problem! -- Cheers Jorge.-
On Fri, Dec 19, 2008 at 03:50:56PM -0300, Jorge Arellano Cid wrote:
On Fri, Dec 19, 2008 at 06:55:07PM +0100, Johannes Hofmann wrote:
On Wed, Dec 17, 2008 at 06:40:24PM +0000, Jeremy Henty wrote:
I was revising the autoconf docs and noticed that make rules should prefix all sources with $(srcdir) to support separate builds[1]. We don't do this, so here's a patch.
Commited! (to http://freehg.org/u/dillo/main) @Jorge: I hope that's ok for you.
Oh, sorry, I thought it was to css-prototype. It was main dillo.
Yeah, non-CSS changes should go into the main repository. They will end up in the css-prototype via the regular merges. That way we can avoid unnecessary merge conflicts. Cheers, Johannes
On Fri, Dec 19, 2008 at 08:38:22PM +0100, Johannes Hofmann wrote:
On Fri, Dec 19, 2008 at 03:50:56PM -0300, Jorge Arellano Cid wrote:
On Fri, Dec 19, 2008 at 06:55:07PM +0100, Johannes Hofmann wrote:
On Wed, Dec 17, 2008 at 06:40:24PM +0000, Jeremy Henty wrote:
I was revising the autoconf docs and noticed that make rules should prefix all sources with $(srcdir) to support separate builds[1]. We don't do this, so here's a patch.
Commited! (to http://freehg.org/u/dillo/main) @Jorge: I hope that's ok for you.
Oh, sorry, I thought it was to css-prototype. It was main dillo.
Yeah, non-CSS changes should go into the main repository. They will end up in the css-prototype via the regular merges. That way we can avoid unnecessary merge conflicts.
OK. BTW, did you try the CSS loading patch I sent you? -- Cheers Jorge.-
On Fri, Dec 19, 2008 at 04:51:21PM -0300, Jorge Arellano Cid wrote:
On Fri, Dec 19, 2008 at 08:38:22PM +0100, Johannes Hofmann wrote:
On Fri, Dec 19, 2008 at 03:50:56PM -0300, Jorge Arellano Cid wrote:
On Fri, Dec 19, 2008 at 06:55:07PM +0100, Johannes Hofmann wrote:
On Wed, Dec 17, 2008 at 06:40:24PM +0000, Jeremy Henty wrote:
I was revising the autoconf docs and noticed that make rules should prefix all sources with $(srcdir) to support separate builds[1]. We don't do this, so here's a patch.
Commited! (to http://freehg.org/u/dillo/main) @Jorge: I hope that's ok for you.
Oh, sorry, I thought it was to css-prototype. It was main dillo.
Yeah, non-CSS changes should go into the main repository. They will end up in the css-prototype via the regular merges. That way we can avoid unnecessary merge conflicts.
OK.
BTW, did you try the CSS loading patch I sent you?
I'm currently testing it. It's fun seeing CSS partly working isn't it? Cheers, Johannes
participants (3)
-
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de -
onepoint＠starurchin.org