On Mon, Nov 12, 2007 at 04:59:34PM +0000, place wrote:
Considering how all of the arguments are bw, do you think the control should go html -> bw -> uicmd -> menu?
The "Load images" via page menu patch was committed. I also made a big cleanup of html.hh. It was exporting data no module besides html.cc was using. With regard to your question, currently we have this dependency graph: ,-------------> menu | ^ -----> timeout | | / | v / | ui <-----> uicmd <-----> nav | ^ ^ \ | | / | \ | | / v \ v '-> html ----' bw ----> dialog ^ | form I don't like the double relation between "html" and "menu". It could be "html" calling "menu" only. For instance if we implement setting a callback function in menu's API for "Load Images". Maybe there's a better way, and I'm not sure, but a least the committed cleanup makes it look much cleaner. ;-) BTW, I also added premliminar activate/deactivate to this menu item. -- Cheers Jorge.-
Jorge wrote:
The "Load images" via page menu patch was committed.
Are you seeing the menus popping up with the load images option under the pointer? What I get looks suspiciously like the previous option clicked plus the height of the control panel. *resizes control panel* Yes, _very_ suspiciously.
On Wed, Nov 14, 2007 at 11:18:17PM +0000, place wrote:
Jorge wrote:
The "Load images" via page menu patch was committed.
Are you seeing the menus popping up with the load images option under the pointer? What I get looks suspiciously like the previous option clicked plus the height of the control panel. *resizes control panel* Yes, _very_ suspiciously.
I'm experiencing the same as you. With the offset being exactly the panel height. No problem at all when the whole panel is hidden. It's possible to workaround by adding an offset inside the a_Menu_*_popup functions, but probably the proper solution is to get the event in window coordinates instead of viewport-based ones. AFAIU the popup offset is OK with pure-fltk2 widgets, so maybe there's a problem in how FLTK2 perceives the viewport or the panel... I haven't investigated further along these lines though... -- Cheers Jorge.-
Jorge wrote:
I don't like the double relation between "html" and "menu". It could be "html" calling "menu" only. For instance if we implement setting a callback function in menu's API for "Load Images".
I'm wondering whether the image list should live in the bw or something. Now that we keep a list of images around, reload should be able to do a proper full reload...
participants (2)
-
jcid＠dillo.org -
place＠gobigwest.com