Hi there! It's been a hard time for me trying to get an Internet connection from where I'm temporary living now. That's the main reason for my abscence (as anticipated). Well, I kept working on the plugins stuff and it shows. Now the CVS has the new code (with unix domain sockets) and the CVS.html page holds the new bookmarks-server tarball. Now dillo launches it automatically and before the release the dpi code for the bookmarks server will be a part of the main tarball. The point is: testing it. Sadly I didn't received more than a single comment of its working. Now I'm asking again: please download the latest CVS, the bookmarks server, intall them, play with them, test and report how it works for you. I want to know how the whole thing looks and feels before making the release. This should be a short span, depending on feedback. Ah, if someone here has NFS mounted accounts (from another machine), I want to know how it works there. As unix domain sockets are accessible only to the local machine, and it listens on /tmp, it should work, but we need the proof! That's all by now guys. I'll be expecting your feedback! Cheers* Jorge.- PS: I'll try to answer some pending issues, but roughly, this CVS plus some cosmetic will be 0.7.0. Pending patches will go to 0.7.1.
Hi Jorge, on Sat, 1 Feb 2003 09:54:34 -0300 (CLST) Jorge Arellano Cid <jcid@softhome.net> wrote:
The point is: testing it. Sadly I didn't received more than a single comment of its working. Now I'm asking again: please download the latest CVS, the bookmarks server, intall them, play with them, test and report how it works for you.
Everything compiled without problems on i686 GNU/Linux. I got one problem: the bm_srv12 displayed the following when it was attempted to open the bookmark page: bm_srv12: accepting connections... [accept]: Invalid argument checking why, I found the bug was that the accept() function was called with an uninitialized *addrlen (third) argument. According to the man page on GNU/Linux, "The addrlen argument is a value-result parameter: it should initially contain the size of the structure pointed to by addr; on return it will contain the actual length (in bytes) of the address returned. When addr is NULL nothing is filled in." So I made the following patch: --- bm_srv12.c Fri Jan 31 17:22:36 2003 +++ bm_srv12_modified.c Sat Feb 1 22:00:23 2003 @@ -1694,7 +1694,7 @@ int main (void) { struct sockaddr_un pun; int sock_descriptor; int temp_sock_descriptor; - int address_size; + int address_size = sizeof(struct sockaddr_un); char buf[16384]; int st, code; Concerning Unix sockets, I read on GNU/Linux' "man 7 unix", that many BSD derivatives do not guarantee the permissions, so anyone could read and modify the bookmarks of another user. That is, unless I missed something. " NOTES In the Linux implementation, sockets which are visible in the filesystem honour the permissions of the directory they are in. Their owner, group and their permissions can be changed. Creation of a new socket will fail if the process does not have write and search (execute) permis sion on the directory the socket is created in. Connect ing to the socket object requires read/write permission. This behavior differs from many BSD derived systems which ignore permissions for Unix sockets. Portable programs should not rely on this feature for security. " However, I do not have any suggestions here. Farvel (Danish: Farewell) -- Melvin Hadasht
On Sat, 1 Feb 2003, Melvin Hadasht wrote:
I got one problem: the bm_srv12 displayed the following when it was attempted to open the bookmark page: bm_srv12: accepting connections... [accept]: Invalid argument
checking why, I found the bug was that the accept() function was called with an uninitialized *addrlen (third) argument. According to the man page on GNU/Linux, "The addrlen argument is a value-result parameter: it should initially contain the size of the structure pointed to by addr; on return it will contain the actual length (in bytes) of the address returned. When addr is NULL nothing is filled in."
So I made the following patch: --- bm_srv12.c Fri Jan 31 17:22:36 2003 +++ bm_srv12_modified.c Sat Feb 1 22:00:23 2003 @@ -1694,7 +1694,7 @@ int main (void) { struct sockaddr_un pun; int sock_descriptor; int temp_sock_descriptor; - int address_size; + int address_size = sizeof(struct sockaddr_un); char buf[16384]; int st, code;
Looked bm_srv code now and discovered variable named "sun" before pun in main function. Which is not a good variable name, when you want to compile it on solaris (solaris c library headers contain something like #define sun 1).
The point is: testing it. Sadly I didn't received more than a single comment of its working. Now I'm asking again: please download the latest CVS, the bookmarks server, intall them, play with them, test and report how it works for you.
I am most likely just stupid, but a fresh download from CVS doesn't work for me. Output from ./configure: telent@frodo:/telent/dillo% ./configure checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for gawk... no checking for mawk... no checking for nawk... nawk checking whether make sets ${MAKE}... yes checking for gcc... gcc checking for C compiler default output... a.out checking whether the C compiler works... yes checking whether we are cross compiling... no checking for suffix of executables... checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for style of include used by make... GNU checking dependency style of gcc... gcc checking for gcc option to accept ANSI C... none needed checking for ranlib... ranlib checking for gtk-config... /usr/local/bin/gtk-config checking for GTK - version >= 1.2.0... yes checking for jpeg_destroy_decompress in -ljpeg... yes checking how to run the C preprocessor... gcc -E checking for ANSI C header files... yes checking for sys/types.h... yes checking for sys/stat.h... yes checking for stdlib.h... yes checking for string.h... yes checking for memory.h... yes checking for strings.h... yes checking for inttypes.h... yes checking for stdint.h... no checking for unistd.h... yes checking jpeglib.h usability... yes checking jpeglib.h presence... yes checking for jpeglib.h... yes checking jconfig.h usability... yes checking jconfig.h presence... yes checking for jconfig.h... yes checking jerror.h usability... yes checking jerror.h presence... yes checking for jerror.h... yes checking jmorecfg.h usability... yes checking jmorecfg.h presence... yes checking for jmorecfg.h... yes checking whether threads work with -pthread... yes checking for zlibVersion in -lz... yes checking for png_check_sig in -lpng... yes checking for ANSI C header files... (cached) yes checking fcntl.h usability... yes checking fcntl.h presence... yes checking for fcntl.h... yes checking for unistd.h... (cached) yes checking sys/uio.h usability... yes checking sys/uio.h presence... yes checking for sys/uio.h... yes checking for socket... yes configure: creating ./config.status config.status: creating Makefile config.status: creating doc/Makefile config.status: creating src/Makefile config.status: creating src/IO/Makefile config.status: creating config.h config.status: executing default-1 commands telent@frodo:/telent/dillo% make cd . && /bin/sh /telent/dillo/missing --run autoheader cd . && /bin/sh /telent/dillo/missing --run autoconf autoconf: Undefined macros: configure.in:153:AC_CONFIG_FILES([Makefile doc/Makefile src/Makefile src/IO/Makefile]) configure.in:4:AC_CONFIG_SRCDIR([src/dillo.c]) WARNING: `autoconf' is missing on your system. You should only need it if you modified `configure.in'. You might want to install the `Autoconf' and `GNU m4' packages. Grab them from any GNU archive site. /bin/sh ./config.status --recheck running /bin/sh ./configure --no-create --no-recursion creating cache ./config.cache ./configure[549]: syntax error: `src/dillo.c' unexpected *** Error code 1 Stop in /telent/dillo (line 108 of Makefile). telent@frodo:/telent/dillo% I *do* have autoconf installed, both 2.13 and 2.52, and I didn't make any changes to configure.in. When I remove ``configure'' and regenerate it with autoconf, I get this: telent@frodo:/telent/dillo% rm configure telent@frodo:/telent/dillo% autoconf autoconf: Undefined macros: configure.in:153:AC_CONFIG_FILES([Makefile doc/Makefile src/Makefile src/IO/Makefile]) configure.in:4:AC_CONFIG_SRCDIR([src/dillo.c]) telent@frodo:/telent/dillo% gmake cd . && \ /bin/sh /telent/dillo/missing --run automake --gnu Makefile /bin/sh ./config.status --recheck running /bin/sh ./configure --no-create --no-recursion loading cache ./config.cache ./configure[549]: syntax error: `src/dillo.c' unexpected gmake: *** [config.status] Error 1 telent@frodo:/telent/dillo% I'm running OpenBSD 3.2-current on i386. If you need further details, I can get them. I'm sure it's just a stupid error of mine. -Sunny Raspet
On Sat, 1 Feb 2003 17:16:36 -0500 Telent <telent@mordac.info> wrote:
I'm running OpenBSD 3.2-current on i386. If you need further details, I can get them. I'm sure it's just a stupid error of mine.
Get the configure script from CVS, and type: touch configure, it worked for me. -- Registered Linux user #298569 Always borrow money from a pessimist; he doesn't expect to be paid back.
telent@frodo:/telent/dillo% rm configure telent@frodo:/telent/dillo% autoconf autoconf: Undefined macros: configure.in:153:AC_CONFIG_FILES([Makefile doc/Makefile src/Makefile src/IO/Makefile]) configure.in:4:AC_CONFIG_SRCDIR([src/dillo.c]) telent@frodo:/telent/dillo% gmake cd . && \ /bin/sh /telent/dillo/missing --run automake --gnu Makefile /bin/sh ./config.status --recheck running /bin/sh ./configure --no-create --no-recursion loading cache ./config.cache ./configure[549]: syntax error: `src/dillo.c' unexpected gmake: *** [config.status] Error 1 telent@frodo:/telent/dillo%
And... In the grand tradition of replying to one's own post... Yes, all my fault. Note to all/self: Dillo will *not* work with autoconf-2.13. -Sunny Raspet
On Sat, 1 Feb 2003 09:54:34 -0300 (CLST) Jorge Arellano Cid <jcid@softhome.net> wrote:
I'll be expecting your feedback!
Latest cvs works ok for me so far, but one q though, when will we be able to copy text from the pages without making dillo revel the source of the page... -- Registered Linux user #298569 There is always one thing to remember: writers are always selling somebody out. -- Joan Didion, "Slouching Towards Bethlehem"
participants (5)
-
Jorge Arellano Cid -
Madis Janson -
Melvin Hadasht -
slymer＠slymer.org -
Telent