[RFC] Last call... remove conditional compilation from tab/fram patch?
Hi'all, Those of you who want to keep the conditional compilation options for tabs and frameset support in the tab/frame patch, speak up now. If I do not get any serious requests in this direction I will remove the conditional compilation options in the next patch (any day now...) and you'll all be stuck with tabs and frames. But... that might be the reason you applied the patch in the first place, so... BTW, the selection issue with the tab/frame patch is solved, I just forgot to set the owner for the selection. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]
Hello, If it will stay a patch always, then you can remove it without problems. I think you should treat the code as if it is offical, so use only conditions where you would normally do, otherwise you may need to add them back later if it's merges with Dillo's code. So the question is, should Dillo have always tabs and/or frames support? Always frame support makes more sense that always tabs support in my opinion, but just an option in dillorc to enable/disable them is probably enough, both runtime and compile time options may be overkill. The choice should be new windows or new tabs, there is not much more annoying than a new window when the browser supports tabs, the user also can't know if the link will change the current page or pop up a new one. Greetings, Indan
Indan Zupancic wrote:
Hello,
If it will stay a patch always, then you can remove it without problems. I think you should treat the code as if it is offical, so use only conditions where you would normally do, otherwise you may need to add them back later if it's merges with Dillo's code. So the question is, should Dillo have always tabs and/or frames support?
Point is, Sebastian (of Dw fame) has stated that he does not like the conditional compilation options as it complicates code maintenance (which is true). My standpoint was that not everyone liked or needed the extended functionality or (more importantly) could spare the memory for it. I have asked several times on the list whether these options should stay or go, but have not gotten a clear 'stay' response. So, I intend to remove the options since there does not seem to be a need for them. On tab/window preferences, there already is a preference to open new windows in tabs (tab_instead_of_window=YES). I will add an option to ignore the _blank target for those who do not like their browser to open new windows or tabs at random (check the archives for some examples of people complaining about this). Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]
* Frank de Lange <frank@unternet.org> [11-13-03 03:25]:
Those of you who want to keep the conditional compilation options for tabs and frameset support in the tab/frame patch, speak up now. If I do not get any serious requests in this direction I will remove the conditional compilation options in the next patch (any day now...) and you'll all be stuck with tabs and frames. But... that might be the reason you applied the patch in the first place, so...
Drop the conditional compilation and provide new-window/tab option in the rc file. tks, -- Patrick Shanahan Registered Linux User #207535 http://wahoo.no-ip.org @ http://counter.li.org
participants (3)
-
Frank de Lange
-
Indan Zupancic
-
Patrick Shanahan