You know how - you are scrolled down or to the right - you make the viewport larger - the scrollbar disappears - you can only get the rest of the document back by hitting some arrow keys or something This seems to fix it, although my usual dw disclaimer applies: I don't know whether this is necessarily the right place for the change. PS When making the viewport very narrow and then maximizing, I notice that the location bar does not go back to showing the whole address. I don't know whether that's dillo's fault or fltk's fault. PPS Amazing how much code we need for dealing with scrolling and scrollbars...
Hi, On Mon, Sep 15, 2008 at 02:57:27AM +0000, corvid wrote:
You know how - you are scrolled down or to the right - you make the viewport larger - the scrollbar disappears - you can only get the rest of the document back by hitting some arrow keys or something
Yes, I know...
This seems to fix it, although my usual dw disclaimer applies: I don't know whether this is necessarily the right place for the change.
I was thinking about something like this before. The only problem I see is with tiling window managers like e.g. dwm: With these windows often get resized, then resized back to their old size. Currently such a resize cycle does not change the scrolling position, which is quite nice. But as most people use ordinary window managers, I'd say we should commit this fix. Perhaps we will find something later that also keeps the scrolling position after resizing back to the original size.
PS When making the viewport very narrow and then maximizing, I notice that the location bar does not go back to showing the whole address. I don't know whether that's dillo's fault or fltk's fault.
PPS Amazing how much code we need for dealing with scrolling and scrollbars...
Yes, that's true. Quite a lot of code actually handles hiding and showing of the scrollbars and their influence on the size of the viewable area. I had proposed a quite radical patch some time ago that moved the scrollbars from the viewport to the gui (and thereby from dw2 to dillo2). This would eliminate all scrollbar related code from dw2. However as I'm not confident enough that I did not miss any subtle effects and the current code works fine I would keep things as they are for the release. I can update my patch and put it up for discussion after the release. Cheers, Johannes
Johannes wrote:
Yes, that's true. Quite a lot of code actually handles hiding and showing of the scrollbars and their influence on the size of the viewable area. I had proposed a quite radical patch some time ago that moved the scrollbars from the viewport to the gui (and thereby from dw2 to dillo2). This would eliminate all scrollbar related code from dw2. However as I'm not confident enough that I did not miss any subtle effects and the current code works fine I would keep things as they are for the release. I can update my patch and put it up for discussion after the release.
It would at least be interesting to see how things are simplified. (Is ScrollGroup involved? I've wondered about it ever since I first noticed it in fltk)
On Mon, Sep 15, 2008 at 06:54:02PM +0000, corvid wrote:
Johannes wrote:
Yes, that's true. Quite a lot of code actually handles hiding and showing of the scrollbars and their influence on the size of the viewable area. I had proposed a quite radical patch some time ago that moved the scrollbars from the viewport to the gui (and thereby from dw2 to dillo2). This would eliminate all scrollbar related code from dw2. However as I'm not confident enough that I did not miss any subtle effects and the current code works fine I would keep things as they are for the release. I can update my patch and put it up for discussion after the release.
It would at least be interesting to see how things are simplified.
(Is ScrollGroup involved? I've wondered about it ever since I first noticed it in fltk)
No, it isn't. Scrolling is still be done separately. However, all the nasty stuff is hidden in fltk::scrollrect() already. The patch just makes the scrollbars part of the UI. Cheers, Johannes
On Mon, Sep 15, 2008 at 05:20:01PM +0200, Johannes Hofmann wrote:
Hi,
On Mon, Sep 15, 2008 at 02:57:27AM +0000, corvid wrote:
You know how - you are scrolled down or to the right - you make the viewport larger - the scrollbar disappears - you can only get the rest of the document back by hitting some arrow keys or something
Yes, I know...
This seems to fix it, although my usual dw disclaimer applies: I don't know whether this is necessarily the right place for the change.
I was thinking about something like this before. The only problem I see is with tiling window managers like e.g. dwm: With these windows often get resized, then resized back to their old size. Currently such a resize cycle does not change the scrolling position, which is quite nice. But as most people use ordinary window managers, I'd say we should commit this fix.
Committed.
Perhaps we will find something later that also keeps the scrolling position after resizing back to the original size.
ACK.
PS When making the viewport very narrow and then maximizing, I notice that the location bar does not go back to showing the whole address. I don't know whether that's dillo's fault or fltk's fault.
PPS Amazing how much code we need for dealing with scrolling and scrollbars...
Yes, that's true. Quite a lot of code actually handles hiding and showing of the scrollbars and their influence on the size of the viewable area. I had proposed a quite radical patch some time ago that moved the scrollbars from the viewport to the gui (and thereby from dw2 to dillo2). This would eliminate all scrollbar related code from dw2. However as I'm not confident enough that I did not miss any subtle effects and the current code works fine I would keep things as they are for the release. I can update my patch and put it up for discussion after the release.
Yes, it would be good to reconsider it. AFAIR the main reasons it wan't committed were the author wasn't 100% confident, and we were expecting some comments. It can be re-considered after the release. -- Cheers Jorge.-
participants (3)
-
corvid＠lavabit.com -
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de