Hi Johannes, Now that I have the image process mostly in my head, I'd like to hook correct image ratio scaling when only one of width/height is given. I see scaling done with the styleengine in a_Html_add_new_image but 'props' goes away when popping the tag. How do I handle this? Do I have to preserve props in the stack until I have the final data, or is there another way? Please explain. -- Cheers Jorge.-
Hi Jorge, On Fri, Jan 09, 2009 at 02:00:20PM -0300, Jorge Arellano Cid wrote:
Hi Johannes,
Now that I have the image process mostly in my head, I'd like to hook correct image ratio scaling when only one of width/height is given.
I see scaling done with the styleengine in a_Html_add_new_image but 'props' goes away when popping the tag. How do I handle this?
Do I have to preserve props in the stack until I have the final data, or is there another way? Please explain.
What about just setting the data that is available (width, height, or both) and let the image do the rest? It already handles the case where neither width nor height are given. So it should be possible to make it work with just width or height too. Am I missing something? Cheers, Johannes
On Fri, Jan 09, 2009 at 06:04:09PM +0100, Hofmann Johannes wrote:
Hi Jorge,
On Fri, Jan 09, 2009 at 02:00:20PM -0300, Jorge Arellano Cid wrote:
Hi Johannes,
Now that I have the image process mostly in my head, I'd like to hook correct image ratio scaling when only one of width/height is given.
I see scaling done with the styleengine in a_Html_add_new_image but 'props' goes away when popping the tag. How do I handle this?
Do I have to preserve props in the stack until I have the final data, or is there another way? Please explain.
What about just setting the data that is available (width, height, or both) and let the image do the rest? It already handles the case where neither width nor height are given. So it should be possible to make it work with just width or height too. Am I missing something?
Yes, the problem is when only one of the dimenssions is given, bacause the other one is only known at image arrival time (much later). i.e. Only once the real dimenssions of the image are known it is possible to calculate the missing one. At this time, props is long gone, and thus the question. -- Cheers Jorge.-
On Fri, Jan 09, 2009 at 04:11:36PM -0300, Jorge Arellano Cid wrote:
On Fri, Jan 09, 2009 at 06:04:09PM +0100, Hofmann Johannes wrote:
Hi Jorge,
On Fri, Jan 09, 2009 at 02:00:20PM -0300, Jorge Arellano Cid wrote:
Hi Johannes,
Now that I have the image process mostly in my head, I'd like to hook correct image ratio scaling when only one of width/height is given.
I see scaling done with the styleengine in a_Html_add_new_image but 'props' goes away when popping the tag. How do I handle this?
Do I have to preserve props in the stack until I have the final data, or is there another way? Please explain.
What about just setting the data that is available (width, height, or both) and let the image do the rest? It already handles the case where neither width nor height are given. So it should be possible to make it work with just width or height too. Am I missing something?
Yes, the problem is when only one of the dimenssions is given, bacause the other one is only known at image arrival time (much later).
i.e. Only once the real dimenssions of the image are known it is possible to calculate the missing one. At this time, props is long gone, and thus the question.
Yes, props is gone, but - if not overridden - it's data will have made it into the style object associated with the image. I guess the calculation of the missing dimension could be done in Image::sizeRequestImpl() or Image::sizeAllocateImpl() but I haven't looked at it enough to know exactly. Cheers, Johannes
On Fri, Jan 09, 2009 at 08:27:17PM +0100, Hofmann Johannes wrote:
On Fri, Jan 09, 2009 at 04:11:36PM -0300, Jorge Arellano Cid wrote:
On Fri, Jan 09, 2009 at 06:04:09PM +0100, Hofmann Johannes wrote:
Hi Jorge,
On Fri, Jan 09, 2009 at 02:00:20PM -0300, Jorge Arellano Cid wrote:
Hi Johannes,
Now that I have the image process mostly in my head, I'd like to hook correct image ratio scaling when only one of width/height is given.
I see scaling done with the styleengine in a_Html_add_new_image but 'props' goes away when popping the tag. How do I handle this?
Do I have to preserve props in the stack until I have the final data, or is there another way? Please explain.
What about just setting the data that is available (width, height, or both) and let the image do the rest? It already handles the case where neither width nor height are given. So it should be possible to make it work with just width or height too. Am I missing something?
Yes, the problem is when only one of the dimenssions is given, bacause the other one is only known at image arrival time (much later).
i.e. Only once the real dimenssions of the image are known it is possible to calculate the missing one. At this time, props is long gone, and thus the question.
Yes, props is gone, but - if not overridden - it's data will have made it into the style object associated with the image.
How do I get to the style object of a dw::Image? (once endElement has been called on it)
I guess the calculation of the missing dimension could be done in Image::sizeRequestImpl() or Image::sizeAllocateImpl() but I haven't looked at it enough to know exactly.
I guess we're in a situation were you know easily the style part and I know how to hook the rest, hence the conversation! :-) The HTML-requested size can be stored in the DilloImage structure, and updated in a_Image_set_parms(). The latter is called by the dicache when the original width and height are known. So at this point we have the requested size, original size and dw:Image well defined. -- Cheers Jorge.-
On Fri, Jan 09, 2009 at 06:53:12PM -0300, Jorge Arellano Cid wrote:
On Fri, Jan 09, 2009 at 08:27:17PM +0100, Hofmann Johannes wrote:
On Fri, Jan 09, 2009 at 04:11:36PM -0300, Jorge Arellano Cid wrote:
On Fri, Jan 09, 2009 at 06:04:09PM +0100, Hofmann Johannes wrote:
Hi Jorge,
On Fri, Jan 09, 2009 at 02:00:20PM -0300, Jorge Arellano Cid wrote:
Hi Johannes,
Now that I have the image process mostly in my head, I'd like to hook correct image ratio scaling when only one of width/height is given.
I see scaling done with the styleengine in a_Html_add_new_image but 'props' goes away when popping the tag. How do I handle this?
Do I have to preserve props in the stack until I have the final data, or is there another way? Please explain.
What about just setting the data that is available (width, height, or both) and let the image do the rest? It already handles the case where neither width nor height are given. So it should be possible to make it work with just width or height too. Am I missing something?
Yes, the problem is when only one of the dimenssions is given, bacause the other one is only known at image arrival time (much later).
i.e. Only once the real dimenssions of the image are known it is possible to calculate the missing one. At this time, props is long gone, and thus the question.
Yes, props is gone, but - if not overridden - it's data will have made it into the style object associated with the image.
How do I get to the style object of a dw::Image? (once endElement has been called on it)
I guess the calculation of the missing dimension could be done in Image::sizeRequestImpl() or Image::sizeAllocateImpl() but I haven't looked at it enough to know exactly.
I guess we're in a situation were you know easily the style part and I know how to hook the rest, hence the conversation! :-)
The HTML-requested size can be stored in the DilloImage structure, and updated in a_Image_set_parms(). The latter is called by the dicache when the original width and height are known. So at this point we have the requested size, original size and dw:Image well defined.
I think the html part needs not be changed. Everything is available in style already. I've attached a quick patch that seems to work for fixed sizes. It does not handle something like width="50%" however. Cheers, Johannes
On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote:
On Fri, Jan 09, 2009 at 06:53:12PM -0300, Jorge Arellano Cid wrote:
On Fri, Jan 09, 2009 at 08:27:17PM +0100, Hofmann Johannes wrote:
On Fri, Jan 09, 2009 at 04:11:36PM -0300, Jorge Arellano Cid wrote:
On Fri, Jan 09, 2009 at 06:04:09PM +0100, Hofmann Johannes wrote:
Hi Jorge,
On Fri, Jan 09, 2009 at 02:00:20PM -0300, Jorge Arellano Cid wrote:
Hi Johannes,
Now that I have the image process mostly in my head, I'd like to hook correct image ratio scaling when only one of width/height is given.
I see scaling done with the styleengine in a_Html_add_new_image but 'props' goes away when popping the tag. How do I handle this?
Do I have to preserve props in the stack until I have the final data, or is there another way? Please explain.
What about just setting the data that is available (width, height, or both) and let the image do the rest? It already handles the case where neither width nor height are given. So it should be possible to make it work with just width or height too. Am I missing something?
Yes, the problem is when only one of the dimenssions is given, bacause the other one is only known at image arrival time (much later).
i.e. Only once the real dimenssions of the image are known it is possible to calculate the missing one. At this time, props is long gone, and thus the question.
Yes, props is gone, but - if not overridden - it's data will have made it into the style object associated with the image.
How do I get to the style object of a dw::Image? (once endElement has been called on it)
I guess the calculation of the missing dimension could be done in Image::sizeRequestImpl() or Image::sizeAllocateImpl() but I haven't looked at it enough to know exactly.
I guess we're in a situation were you know easily the style part and I know how to hook the rest, hence the conversation! :-)
The HTML-requested size can be stored in the DilloImage structure, and updated in a_Image_set_parms(). The latter is called by the dicache when the original width and height are known. So at this point we have the requested size, original size and dw:Image well defined.
I think the html part needs not be changed. Everything is available in style already. I've attached a quick patch that seems to work for fixed sizes. It does not handle something like width="50%" however.
As the patch works rather well for me and improves the current behaviour, I've cleaned it up a bit (avoiding a possible division by 0) for inclusion into main. Cheers, Johannes
On Sat, Jan 10, 2009 at 02:07:57PM +0100, Hofmann Johannes wrote:
On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote:
On Fri, Jan 09, 2009 at 06:53:12PM -0300, Jorge Arellano Cid wrote:
On Fri, Jan 09, 2009 at 08:27:17PM +0100, Hofmann Johannes wrote:
On Fri, Jan 09, 2009 at 04:11:36PM -0300, Jorge Arellano Cid wrote:
On Fri, Jan 09, 2009 at 06:04:09PM +0100, Hofmann Johannes wrote:
Hi Jorge,
On Fri, Jan 09, 2009 at 02:00:20PM -0300, Jorge Arellano Cid wrote: > Hi Johannes, > > Now that I have the image process mostly in my head, I'd like > to hook correct image ratio scaling when only one of width/height > is given. > > I see scaling done with the styleengine in a_Html_add_new_image > but 'props' goes away when popping the tag. How do I handle this? > > Do I have to preserve props in the stack until I have the > final data, or is there another way? Please explain.
What about just setting the data that is available (width, height, or both) and let the image do the rest? It already handles the case where neither width nor height are given. So it should be possible to make it work with just width or height too. Am I missing something?
Yes, the problem is when only one of the dimenssions is given, bacause the other one is only known at image arrival time (much later).
i.e. Only once the real dimenssions of the image are known it is possible to calculate the missing one. At this time, props is long gone, and thus the question.
Yes, props is gone, but - if not overridden - it's data will have made it into the style object associated with the image.
How do I get to the style object of a dw::Image? (once endElement has been called on it)
I guess the calculation of the missing dimension could be done in Image::sizeRequestImpl() or Image::sizeAllocateImpl() but I haven't looked at it enough to know exactly.
I guess we're in a situation were you know easily the style part and I know how to hook the rest, hence the conversation! :-)
The HTML-requested size can be stored in the DilloImage structure, and updated in a_Image_set_parms(). The latter is called by the dicache when the original width and height are known. So at this point we have the requested size, original size and dw:Image well defined.
I think the html part needs not be changed. Everything is available in style already. I've attached a quick patch that seems to work for fixed sizes. It does not handle something like width="50%" however.
As the patch works rather well for me and improves the current behaviour, I've cleaned it up a bit (avoiding a possible division by 0) for inclusion into main.
Committed! I'm stuck chasing what looks like a weird bug in the image code... (not from this patch). -- Cheers Jorge.-
Johannes wrote:
On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote:
I think the html part needs not be changed. Everything is available in style already. I've attached a quick patch that seems to work for fixed sizes. It does not handle something like width="50%" however.
As the patch works rather well for me and improves the current behaviour, I've cleaned it up a bit (avoiding a possible division by 0) for inclusion into main.
Loading an image scales properly for me, but I still see lack of scaling when I leave a page and come back. Is that supposed to work now?
On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote:
Johannes wrote:
On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote:
I think the html part needs not be changed. Everything is available in style already. I've attached a quick patch that seems to work for fixed sizes. It does not handle something like width="50%" however.
As the patch works rather well for me and improves the current behaviour, I've cleaned it up a bit (avoiding a possible division by 0) for inclusion into main.
Loading an image scales properly for me, but I still see lack of scaling when I leave a page and come back. Is that supposed to work now?
Yes, it is supposed to work. Altough now that you mention it, I have problems the *first* time a only-one-dimension-specified image tag is loaded. Once coming back it works OK. This is because the second time the image dimensions are known from the dicache. Patch 8f7293125059 from main fixes this. Johannes: please test and merge. -- Cheers Jorge.-
On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote:
On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote:
Johannes wrote:
On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote:
I think the html part needs not be changed. Everything is available in style already. I've attached a quick patch that seems to work for fixed sizes. It does not handle something like width="50%" however.
As the patch works rather well for me and improves the current behaviour, I've cleaned it up a bit (avoiding a possible division by 0) for inclusion into main.
Loading an image scales properly for me, but I still see lack of scaling when I leave a page and come back. Is that supposed to work now?
Yes, it is supposed to work.
Altough now that you mention it, I have problems the *first* time a only-one-dimension-specified image tag is loaded. Once coming back it works OK. This is because the second time the image dimensions are known from the dicache.
Patch 8f7293125059 from main fixes this.
Johannes: please test and merge.
Done. corvid, can you please verify that this fixes the issue you were seeing? Cheers, Johannes
Johannes wrote:
On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote:
On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote:
Johannes wrote:
On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote:
I think the html part needs not be changed. Everything is available in style already. I've attached a quick patch that seems to work for fixed sizes. It does not handle something like width="50%" however.
As the patch works rather well for me and improves the current behaviour, I've cleaned it up a bit (avoiding a possible division by 0) for inclusion into main.
Loading an image scales properly for me, but I still see lack of scaling when I leave a page and come back. Is that supposed to work now?
Yes, it is supposed to work.
Altough now that you mention it, I have problems the *first* time a only-one-dimension-specified image tag is loaded. Once coming back it works OK. This is because the second time the image dimensions are known from the dicache.
Patch 8f7293125059 from main fixes this.
Johannes: please test and merge.
Done.
corvid, can you please verify that this fixes the issue you were seeing?
Same problem for me still. It turns out that <img src="http://www.dillo.org/wearlab.png" height=20> in isolation works fine, but <a href="http://auriga.wearlab.de/"> <img src="http://www.dillo.org/wearlab.png" height=20> </a> doesn't.
I wrote:
Johannes wrote:
On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote:
On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote:
Johannes wrote:
On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote:
I think the html part needs not be changed. Everything is available in style already. I've attached a quick patch that seems to work for fixed sizes. It does not handle something like width="50%" however.
As the patch works rather well for me and improves the current behaviour, I've cleaned it up a bit (avoiding a possible division by 0) for inclusion into main.
Loading an image scales properly for me, but I still see lack of scaling when I leave a page and come back. Is that supposed to work now?
Yes, it is supposed to work.
Altough now that you mention it, I have problems the *first* time a only-one-dimension-specified image tag is loaded. Once coming back it works OK. This is because the second time the image dimensions are known from the dicache.
Patch 8f7293125059 from main fixes this.
Johannes: please test and merge.
Done.
corvid, can you please verify that this fixes the issue you were seeing?
Same problem for me still. It turns out that
<img src="http://www.dillo.org/wearlab.png" height=20>
in isolation works fine, but
<a href="http://auriga.wearlab.de/"> <img src="http://www.dillo.org/wearlab.png" height=20> </a>
doesn't.
Ah, it works for me with css-prototype but not with main. I didn't realize there would be any difference. Sorry for any confusion...
On Sun, Jan 11, 2009 at 05:09:24PM +0000, corvid wrote:
I wrote:
Johannes wrote:
On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote:
On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote:
Johannes wrote:
On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > I think the html part needs not be changed. Everything is available > in style already. > I've attached a quick patch that seems to work for fixed sizes. > It does not handle something like width="50%" however.
As the patch works rather well for me and improves the current behaviour, I've cleaned it up a bit (avoiding a possible division by 0) for inclusion into main.
Loading an image scales properly for me, but I still see lack of scaling when I leave a page and come back. Is that supposed to work now?
Yes, it is supposed to work.
Altough now that you mention it, I have problems the *first* time a only-one-dimension-specified image tag is loaded. Once coming back it works OK. This is because the second time the image dimensions are known from the dicache.
Patch 8f7293125059 from main fixes this.
Johannes: please test and merge.
Done.
corvid, can you please verify that this fixes the issue you were seeing?
Same problem for me still. It turns out that
<img src="http://www.dillo.org/wearlab.png" height=20>
in isolation works fine, but
<a href="http://auriga.wearlab.de/"> <img src="http://www.dillo.org/wearlab.png" height=20> </a>
doesn't.
Ah, it works for me with css-prototype but not with main. I didn't realize there would be any difference.
There shouldn't be any difference...
Sorry for any confusion...
I'm confused now. Cheers, Johannes
Johannes wrote:
On Sun, Jan 11, 2009 at 05:09:24PM +0000, corvid wrote:
I wrote:
Johannes wrote:
On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote:
On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote:
Johannes wrote: > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > I think the html part needs not be changed. Everything is available > > in style already. > > I've attached a quick patch that seems to work for fixed sizes. > > It does not handle something like width="50%" however. > > As the patch works rather well for me and improves the current > behaviour, I've cleaned it up a bit (avoiding a possible division by > 0) for inclusion into main.
Loading an image scales properly for me, but I still see lack of scaling when I leave a page and come back. Is that supposed to work now?
Yes, it is supposed to work.
Altough now that you mention it, I have problems the *first* time a only-one-dimension-specified image tag is loaded. Once coming back it works OK. This is because the second time the image dimensions are known from the dicache.
Patch 8f7293125059 from main fixes this.
Johannes: please test and merge.
Done.
corvid, can you please verify that this fixes the issue you were seeing?
Same problem for me still. It turns out that
<img src="http://www.dillo.org/wearlab.png" height=20>
in isolation works fine, but
<a href="http://auriga.wearlab.de/"> <img src="http://www.dillo.org/wearlab.png" height=20> </a>
doesn't.
Ah, it works for me with css-prototype but not with main. I didn't realize there would be any difference.
There shouldn't be any difference...
main works for you, then? Hmm. It gets the size of the box right, but then the rgb data inside it isn't scaled. (...which is the behaviour I've always seen with fltk-era dillo when returning to pages. On the original load, I would get stretched images, but that's been fixed now.)
On Sun, Jan 11, 2009 at 06:31:35PM +0000, corvid wrote:
Johannes wrote:
On Sun, Jan 11, 2009 at 05:09:24PM +0000, corvid wrote:
I wrote:
Johannes wrote:
On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote:
On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > Johannes wrote: > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > I think the html part needs not be changed. Everything is available > > > in style already. > > > I've attached a quick patch that seems to work for fixed sizes. > > > It does not handle something like width="50%" however. > > > > As the patch works rather well for me and improves the current > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > 0) for inclusion into main. > > Loading an image scales properly for me, but I still see > lack of scaling when I leave a page and come back. > Is that supposed to work now?
Yes, it is supposed to work.
Altough now that you mention it, I have problems the *first* time a only-one-dimension-specified image tag is loaded. Once coming back it works OK. This is because the second time the image dimensions are known from the dicache.
Patch 8f7293125059 from main fixes this.
Johannes: please test and merge.
Done.
corvid, can you please verify that this fixes the issue you were seeing?
Same problem for me still. It turns out that
<img src="http://www.dillo.org/wearlab.png" height=20>
in isolation works fine, but
<a href="http://auriga.wearlab.de/"> <img src="http://www.dillo.org/wearlab.png" height=20> </a>
doesn't.
Ah, it works for me with css-prototype but not with main. I didn't realize there would be any difference.
There shouldn't be any difference...
main works for you, then? Hmm.
It works for me.
It gets the size of the box right, but then the rgb data inside it isn't scaled.
(...which is the behaviour I've always seen with fltk-era dillo when returning to pages. On the original load, I would get stretched images, but that's been fixed now.)
If main doesn't work for you, please share the sample HTML/img code that faults? -- Cheers Jorge.-
On Sun, Jan 11, 2009 at 03:38:04PM -0300, Jorge Arellano Cid wrote:
On Sun, Jan 11, 2009 at 06:31:35PM +0000, corvid wrote:
Johannes wrote:
On Sun, Jan 11, 2009 at 05:09:24PM +0000, corvid wrote:
I wrote:
Johannes wrote:
On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote: > On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > > Johannes wrote: > > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > > I think the html part needs not be changed. Everything is available > > > > in style already. > > > > I've attached a quick patch that seems to work for fixed sizes. > > > > It does not handle something like width="50%" however. > > > > > > As the patch works rather well for me and improves the current > > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > > 0) for inclusion into main. > > > > Loading an image scales properly for me, but I still see > > lack of scaling when I leave a page and come back. > > Is that supposed to work now? > > Yes, it is supposed to work. > > Altough now that you mention it, I have problems the *first* > time a only-one-dimension-specified image tag is loaded. Once coming back > it works OK. This is because the second time the image dimensions > are known from the dicache. > > Patch 8f7293125059 from main fixes this. > > Johannes: please test and merge.
Done.
corvid, can you please verify that this fixes the issue you were seeing?
Same problem for me still. It turns out that
<img src="http://www.dillo.org/wearlab.png" height=20>
in isolation works fine, but
<a href="http://auriga.wearlab.de/"> <img src="http://www.dillo.org/wearlab.png" height=20> </a>
doesn't.
Ah, it works for me with css-prototype but not with main. I didn't realize there would be any difference.
There shouldn't be any difference...
main works for you, then? Hmm.
It works for me.
Try going to: <a href="http://auriga.wearlab.de/"> <img src="http://www.dillo.org/wearlab.png" height=20> </a> then hit the bookmark button and then go back to the above page. First time scaling works, but when going back it's not scaled anymore. Cheers, Johannes
On Sun, Jan 11, 2009 at 07:40:20PM +0100, Hofmann Johannes wrote:
On Sun, Jan 11, 2009 at 03:38:04PM -0300, Jorge Arellano Cid wrote:
On Sun, Jan 11, 2009 at 06:31:35PM +0000, corvid wrote:
Johannes wrote:
On Sun, Jan 11, 2009 at 05:09:24PM +0000, corvid wrote:
I wrote:
Johannes wrote: > On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote: > > On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > > > Johannes wrote: > > > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > > > I think the html part needs not be changed. Everything is available > > > > > in style already. > > > > > I've attached a quick patch that seems to work for fixed sizes. > > > > > It does not handle something like width="50%" however. > > > > > > > > As the patch works rather well for me and improves the current > > > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > > > 0) for inclusion into main. > > > > > > Loading an image scales properly for me, but I still see > > > lack of scaling when I leave a page and come back. > > > Is that supposed to work now? > > > > Yes, it is supposed to work. > > > > Altough now that you mention it, I have problems the *first* > > time a only-one-dimension-specified image tag is loaded. Once coming back > > it works OK. This is because the second time the image dimensions > > are known from the dicache. > > > > Patch 8f7293125059 from main fixes this. > > > > Johannes: please test and merge. > > Done. > > corvid, can you please verify that this fixes the issue you were > seeing?
Same problem for me still. It turns out that
<img src="http://www.dillo.org/wearlab.png" height=20>
in isolation works fine, but
<a href="http://auriga.wearlab.de/"> <img src="http://www.dillo.org/wearlab.png" height=20> </a>
doesn't.
Ah, it works for me with css-prototype but not with main. I didn't realize there would be any difference.
There shouldn't be any difference...
main works for you, then? Hmm.
It works for me.
Try going to:
<a href="http://auriga.wearlab.de/"> <img src="http://www.dillo.org/wearlab.png" height=20> </a>
then hit the bookmark button and then go back to the above page. First time scaling works, but when going back it's not scaled anymore.
Got it! Thxs. -- Cheers Jorge.-
On Sun, Jan 11, 2009 at 06:31:35PM +0000, corvid wrote:
Johannes wrote:
On Sun, Jan 11, 2009 at 05:09:24PM +0000, corvid wrote:
I wrote:
Johannes wrote:
On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote:
On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > Johannes wrote: > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > I think the html part needs not be changed. Everything is available > > > in style already. > > > I've attached a quick patch that seems to work for fixed sizes. > > > It does not handle something like width="50%" however. > > > > As the patch works rather well for me and improves the current > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > 0) for inclusion into main. > > Loading an image scales properly for me, but I still see > lack of scaling when I leave a page and come back. > Is that supposed to work now?
Yes, it is supposed to work.
Altough now that you mention it, I have problems the *first* time a only-one-dimension-specified image tag is loaded. Once coming back it works OK. This is because the second time the image dimensions are known from the dicache.
Patch 8f7293125059 from main fixes this.
Johannes: please test and merge.
Done.
corvid, can you please verify that this fixes the issue you were seeing?
Same problem for me still. It turns out that
<img src="http://www.dillo.org/wearlab.png" height=20>
in isolation works fine, but
<a href="http://auriga.wearlab.de/"> <img src="http://www.dillo.org/wearlab.png" height=20> </a>
doesn't.
Ah, it works for me with css-prototype but not with main. I didn't realize there would be any difference.
There shouldn't be any difference...
main works for you, then? Hmm.
It gets the size of the box right, but then the rgb data inside it isn't scaled.
Ok, I'm seeing the problem now with main and the example you have provided. css-prototype indeed seems to work fine. Not sure why :-) Cheers, Johannes
participants (3)
-
corvid＠lavabit.com -
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de