Hello Fellow Dillo Users! I've written a patch to show a drop down menu for images (BUG #283). I'm very new to Dillo development, so I'd like your comments on the patch. I have put it on a website at: http://wwwcsif.cs.ucdavis.edu/~horie/patch.html Please take a look, and send me comments on what I did right/wrong or could improve on. Thanks! --Takahiro
Takahiro,
Hello Fellow Dillo Users!
Hi!
I've written a patch to show a drop down menu for images (BUG #283). I'm very new to Dillo development, so I'd like your comments on the patch. I have put it on a website at:
:-)
Please take a look, and send me comments on what I did right/wrong or could improve on.
I reviewed the patch information (and skimmed it too). Certainly that functionality is desired. BTW, a long time ago Eric made a patch that made just that but that presented an inactive menu entry when the link wasn't an image... The point (to be consistent with the rest of the interface) is to make the image-menu popup when righ-clicking over an image. If you can do that, great! Ah, last but not the least: /CVS directories should be left out of the patch (they aren't a part of dillo). In a similar way, Makefiles, should be excluded as they are generated... Good idea, clear information. I hope to hear from you soon! Cheers Jorge.-
Ah, last but not the least: /CVS directories should be left out of the patch (they aren't a part of dillo). In a similar way, Makefiles, should be excluded as they are generated...
By the way, there are some files in the CVS repository that can be generated from other files, namely autotools-related stuff. These files should disappear from the CVS version, IMHO. Even if you supply your configure script via CVS, when running cvs update sometimes one needs (happened to me for example ;-)) to run the autotools to update the configure script and the Makefiles. And the next time you run CVS update you have the annoying messages of files being modified (M configure M Makefile.in etc.). In any case, I think it's good policy to exclude from CVS all files that can be generated automatically from other files in the same module. My 2 (euro)cents.
participants (3)
-
Jorge Arellano Cid
-
Nicola Girardi
-
Takahiro Horie