[PATCH] Reverse scroll wheel tab switching
Hi Alex, We have a mailing list for patches at <dillo-dev@mailman3.com>, maybe I should add a comment to the README too. Regarding your patch, I find that behavior unintuitive :-) But we shouldn't expect people to agree on those, so I think this should be implemented as a configuration option. Check the PR of the tab switching[1] to see how to add another option yourself. [1]: https://github.com/dillo-browser/dillo/pull/62/files Otherwise I can work on it after the 3.1.0 release. I opened an issue: https://github.com/dillo-browser/dillo/issues/122 Best, Rodrigo. ----- Forwarded message from Alex ----- Hello, In my opinion the behavior of the mouse wheel tab switching is backwards. Scrolling up switches to the previous tab, and down goes to the next tab. This seems unintuitive and I find myself frequently scrolling in the wrong direction. Sorry I don't have a github account to do a pull request, but here is a diff that reverses the direction: --- uicmd.cc Fri Apr 5 10:59:06 2024 +++ uicmd.cc Fri Apr 5 10:59:21 2024 @@ -255,9 +255,9 @@ int dir = dy ? dy : dx; if (dir > 0) - next_tab(); - else if (dir < 0) prev_tab(); + else if (dir < 0) + next_tab(); ret = 1; } Dillo for life! Alex ----- End forwarded message -----
Hi,
Hi Rodrigo, thanks for your reply!
I agree that a configuration option for the scroll direction would be ideal, and probably wouldn't take a huge effort to implement. I'm not much of a coder, but will take a look to see it's something I can manage.
Thanks!
I did notice the new mailing list and hopefully it starts to get more contributors/activity. It is however somewhat ironic that it requires javascript to view the archives.
I'm able to read the archives without JS in Dillo, as well as performing searches: $ dillo "https://lists.mailman3.com/hyperkitty/list/dillo-dev@mailman3.com/latest" $ dillo "https://lists.mailman3.com/hyperkitty/search?mlist=dillo-dev%40mailman3.com&q=plugin" $ dillo "https://lists.mailman3.com/hyperkitty/list/dillo-dev@mailman3.com/thread/2SE..." AFAIK, the only thing that requires JS is the "Recently active discussions" sections, but clicking on "All threads" works fine. It is non-ideal that it uses JS for some things, but they provide hosting for the ML free of charge. Maybe we can add the mailing list to other indexes that don't use JS. I contacted gmane.io for NNTP access but they didn't replied yet.
Another feature I would be interested in is setting a new tab destination. For instance, it would be neat to show bookmarks automatically when opening a new tab. Is this something which has been looked at already?
I don't think so, but it may be a good feature. It should be similar to adding a "start_page" or "home" option in dillorc, like "new_tab_page". For now you can do Ctrl+T and then Crtl+B to open the bookmarks. It should also allow Ctrl+T and begin typing an URL somhow, maybe we can pre-select the URL.
Really looking forward to the 3.1 release! I run OpenBSD, and the version of Dillo in the packages is old and SSL doesn't work properly. So I have to build from source on every install. Luckily it builds on OpenBSD without problems (using mbedtls).
Thanks! I'll probably do a release candidate before the final release, so it can be tested from the tarball. It should build with OpenSSL 3 and 1.1 and LibreSSL too.
Best regards, and thanks for keeping this project alive!
Thanks :-) Rodrigo.
participants (2)
-
a1ex＠dismail.de -
Rodrigo Arias