make instant meta-refresh optional?
I was just trying to look up a local place on Google Maps, and found that the page wouldn't render any more. So I investigated, and it turns out to be a combination of two problems: - Dillo now follows instant meta-refresh commands, instead of letting the user decide. - Google Maps redirects to a 'mobile' version of the site, which fails to recognize Dillo's user-agent string and returns WML instead of HTML. (I sent them info about this bug a few moments ago; hopefully they'll fix it) Would it be possible to make that first one optional? Maybe a config variable or something? I liked the old behavior much better. The change was introduced here: changeset: 1037:a72e5506e280 user: Jorge Arellano Cid <jcid@dillo.org> date: Sat Apr 18 16:16:18 2009 -0400 summary: Implemented Instant client-side redirects (META refresh with delay=0) For now, I've been building with this small patch: --- a/src/html.cc Wed Apr 07 22:07:07 2010 +0000 +++ b/src/html.cc Wed Apr 14 19:15:12 2010 -0600 @@ -2883,7 +2883,7 @@ mr_url = dStrdup(content); } - if (delay == 0) { + if (0) { /* zero-delay redirection */ html->stop_parser = true; DilloUrl *new_url = a_Url_new(mr_url, URL_STR(html->base_url)); -- Scott
Scott wrote:
I was just trying to look up a local place on Google Maps, and found that the page wouldn't render any more. So I investigated, and it turns out to be a combination of two problems:
- Dillo now follows instant meta-refresh commands, instead of letting the user decide.
- Google Maps redirects to a 'mobile' version of the site, which fails to recognize Dillo's user-agent string and returns WML instead of HTML. (I sent them info about this bug a few moments ago; hopefully they'll fix it)
Would it be possible to make that first one optional? Maybe a config variable or something? I liked the old behavior much better.
I rather liked the old behavior as well.
On Wed, 14 Apr 2010 19:19:42 -0600, Scott Scriven wrote:
I was just trying to look up a local place on Google Maps, and found that the page wouldn't render any more. So I investigated, and it turns out to be a combination of two problems:
- Dillo now follows instant meta-refresh commands, instead of letting the user decide.
- Google Maps redirects to a 'mobile' version of the site, which fails to recognize Dillo's user-agent string and returns WML instead of HTML. (I sent them info about this bug a few moments ago; hopefully they'll fix it)
I was just about to post about the second point :P. Fixing the first still wouldn't make the second work? (Why can't dillo read WML?)
* Dennis Nezic <dennisn@dennisn.dyndns.org> wrote:
On Wed, 14 Apr 2010 19:19:42 -0600, Scott Scriven wrote:
- Google Maps redirects to a 'mobile' version of the site, which fails to recognize Dillo's user-agent string and returns WML instead of HTML. (I sent them info about this bug a few moments ago; hopefully they'll fix it)
I was just about to post about the second point :P. Fixing the first still wouldn't make the second work?
If I disable meta refresh, I can still use the maps site to a limited extent. Or, if I change the user-agent to Mozilla, I can use the HTML version of the mobile interface. Unfortunately, changing the user-agent breaks images.google, because it sends fancy AJAX stuff with no static fallback. And I kinda like to keep Dillo in my user-agent as a way to advertise.
(Why can't dillo read WML?)
... because Dillo is a HTML browser? WML is a totally different language. -- Scott
On Wed, Apr 14, 2010 at 07:19:42PM -0600, Scott Scriven wrote:
I was just trying to look up a local place on Google Maps, and found that the page wouldn't render any more. So I investigated, and it turns out to be a combination of two problems:
- Dillo now follows instant meta-refresh commands, instead of letting the user decide.
- Google Maps redirects to a 'mobile' version of the site, which fails to recognize Dillo's user-agent string and returns WML instead of HTML. (I sent them info about this bug a few moments ago; hopefully they'll fix it)
Would it be possible to make that first one optional? Maybe a config variable or something? I liked the old behavior much better.
The problem is that W3C has zero delay redirection as an standard. I think a "follow_zero_redirects" dillorc option is a good solution. -- Cheers Jorge.-
* Jorge Arellano Cid <jcid@dillo.org> wrote:
The problem is that W3C has zero delay redirection as an standard. I think a "follow_zero_redirects" dillorc option is a good solution.
Sounds perfect! Sorry I didn't include a patch to implement it... I'm not sure how the config mechanisms work, and didn't know whether there was any chance of getting the change accepted. -- Scott
Scott wrote:
* Jorge Arellano Cid <jcid@dillo.org> wrote:
The problem is that W3C has zero delay redirection as an standard. I think a "follow_zero_redirects" dillorc option is a good solution.
Sounds perfect!
Sorry I didn't include a patch to implement it... I'm not sure how the config mechanisms work, and didn't know whether there was any chance of getting the change accepted.
If you take a look at how other prefs are introduced, e.g. http://hg.dillo.org/dillo/rev/c47ab3201464 it's not too complicated. I would lean toward using a name more like follow_zero_delay_refresh...
On Fri, Apr 16, 2010 at 12:24:17AM +0000, corvid wrote:
Scott wrote:
* Jorge Arellano Cid <jcid@dillo.org> wrote:
The problem is that W3C has zero delay redirection as an standard. I think a "follow_zero_redirects" dillorc option is a good solution.
Sounds perfect!
Sorry I didn't include a patch to implement it... I'm not sure how the config mechanisms work, and didn't know whether there was any chance of getting the change accepted.
If you take a look at how other prefs are introduced, e.g. http://hg.dillo.org/dillo/rev/c47ab3201464 it's not too complicated.
I would lean toward using a name more like follow_zero_delay_refresh...
+1 -- Cheers Jorge.-
participants (4)
-
corvid＠lavabit.com -
dennisn＠dennisn.dyndns.org -
dillo-dev＠toykeeper.net -
jcid＠dillo.org