On Sat, May 09, 2009 at 04:13:08PM +0100, Jeremy Henty wrote:
On Sat, May 09, 2009 at 10:00:55AM -0400, Jorge Arellano Cid wrote:
On Sat, May 09, 2009 at 10:27:34AM +0100, Jeremy Henty wrote:
The valgrind logs[1] show a recent burst of errors from calls to Nav_repush().
Oh, here I can't reproduce that. I've tried with some sites and the valgrind log here is clean (a bit better than it used to be). Do you have an example URL or test case?
Not yet. I'll see what I can dig out of the logs.
I've found this: ==9830== 1,420 (352 direct, 1,068 indirect) bytes in 11 blocks are definitely lost in loss record 153 of 192 ==9830== at 0x4025D2E: malloc (vg_replace_malloc.c:207) ==9830== by 0x8081270: dMalloc (dlib.c:36) ==9830== by 0x807E46A: a_Image_new (image.cc:40) ==9830== by 0x80703C5: a_Html_image_new(DilloHtml*, char const*, int, _DilloUrl*) (html.cc:2067) ==9830== by 0x8074F49: _ZL16Html_input_imageP9DilloHtmlPKci (form.cc:1905) ==9830== by 0x8078C5A: Html_tag_open_input(DilloHtml*, char const*, int) (form.cc:484) ==9830== by 0x8071F71: _ZL16Html_process_tagP9DilloHtmlPci (html.cc:3455) ==9830== by 0x80725E8: _ZL14Html_write_rawP9DilloHtmlPcii (html.cc:3756) ==9830== by 0x807276F: DilloHtml::write(char*, int, int) (html.cc:573) ==9830== by 0x8072802: _ZL13Html_callbackiP12_CacheClient (html.cc:3647) ==9830== by 0x8060BC7: Cache_process_queue (cache.c:1154) ==9830== by 0x80603A0: a_Cache_process_dbuf (cache.c:876) in www.lacuarta.cl
BTW, I'm talking about the vanilla repository. Are you testing with a patched repo?
Yes. If it continues I'll back out any relevant patches and see if it changes anything. I've added a list of my local patches to the valgrind log page so that developers can see what I've done.
http://starurchin.org/dillo/valgrind.html
The only two that could (I think) possibly be relevant are:
http://starurchin.org/dillo/patch/img_ref.diff.txt http://starurchin.org/dillo/patch/make-a_Cache_stop_client-close-client.txt
The first patch was suggested to me by the list when I first reported the image access problems, the second is my attempt to fix it. I'd really appreciate any comments on whether they are doing things the right way.
Now I'm working on this, comments should follow along the way. Please check whether the reported errors also happen in the vanilla repo. -- Cheers Jorge.-