Re-sending, because the patch was missing some spaces. corvid (2009-05-03 23:01):
Jorge wrote:
The patch is not 100% complete. For instance there's a need to provide a default keysrc file in a similar way that cookiesrc or dillorc (with useful comments).
Started looking into making a default keysrc.
Some of the bindings in keys.cc are not the same as those in dillo2-help.html. Is that intentional?
What is the purpose of KEYS_HIDE_PANELS when we have KEYS_FULLSCREEN?
Hello, I'm also wondering why KEYS_HIDE_PANELS is there, since KEYS_FULLSCREEN works fine. It seems to have been merged by Jorge together with the configurable keybindings patch, but I think the functionality was actually proposed by Tim. So I'm bumping this thread and also attaching a small patch, which fixes an omission during the configurable keys merge. The following code was removed from ui.cc, and I think it should be added to keys.cc (currently, no keybindings work if numlock is on): - // We're only interested in some flags - unsigned modifier = event_state() & (SHIFT | CTRL | ALT); And one more question: why are the Button1, Button2, Button3 modifierNames there? And one more suggestion: wouldn't it be more intuitive to have "command = keybinding" instead of "keybinding = command"? Now the keysrc file will look like this: Esc = hide-panels <Ctrl>a = hide-panels , = back Backspace = back . = forward <Shift>Backspace = forward while it could be: hide-panels = Esc hide-panels = <Ctrl>a back = , back = Backspace forward = . forward = <Shift>Backspace -- -- Rogut?s Sparnuotos