Hi Jorge, On Sun, Nov 25, 2007 at 02:28:55PM -0300, Jorge Arellano Cid wrote:
Hi there,
A new, weighted apportionment algorithm for table rowspans was committed. This wasn't implemented in dillo2, and the algorithm is different from the one in dillo1.
This produces much better table rendering when rowspan is used (if there's no rowspan in the table, it's the same as before). You can notice the rowspan case in the Web because of a stdout message like this one:
"Short cell 0, sumRows=66 ih=110"
It is interesting to compare dillo2.old, dillo2.rowspan, dillo1 and firefox. You can use:
http://www.dillo.org/test/rowspan.html
Sebastian: I added some comments in rounding-errors.doc, explained the algorithm, including a formula. I also corrected an index in the previous section. Please check it in rounding-errors.html after re-running doxygen, or in the attached patch (already in CVS).
Notes:
* In the test page above, the last table in the second set shows "cellspacing" is not working. AFAIU this is not implemented and subject to another patch.
* The vertical alignment of a cell content is not yet implemented in dillo2. That's why the cell content is aligned at the top instead of the middle (default, as firefox does). This is subject of another patch.
* The same algorithm may be used for width apportionment. I'm not sure on this though.
Sebastian: are you planning to work on this soon? If not, I can try to work on the above mentioned problems. Advice welcomed!
Everybody: please enjoy this patch, it was a lot of work! :-) if you find a URL where it helps, I'd appreciate some feedback.
It helps on http://www.heise.de With the patch the news start on top of the page - as they should. Thanks for your work on this! Johannes