On Mon, Jan 18, 2010 at 03:40:31PM -0300, Jorge Arellano Cid wrote:
On Tue, Jan 12, 2010 at 06:48:19PM +0100, Johannes Hofmann wrote:
On Tue, Dec 08, 2009 at 06:56:55PM +0100, Johannes Hofmann wrote:
Hi,
I started to experiment with the real solution, which means that the display member of Style determines whether a (Text)block is created or a ListItem, or whether just normal text is added. The patch is still small, but as the change is pretty fundamental, so I decided to put it in a separate repo for now. You can find it at:
I've updated this prototype a bit. It works quite well, the only drawback is the added complexity in html.cc. In addition to Html_tag_open_*() and Html_tag_clone_*(), there now is an optional Html_tag_content_*() function for tags that create widgets or other content. This function is not called in the display:none case. The reason for the splitting into Html_tag_open_*() and Html_tag_content_*() is that styleEngine->setNonCssHints() is needed before we can get the current style. Only after that is done, we know the value of the display property and can decide whether to call Html_tag_content_*() or not.
I'd like to get this into main line soon if you agree. Please let me know what you think.
I checked the last repo, and AFAIS it's OK to merge.
I agreed with corvid to leave it out until after the release.
Notes:
- I agree with corvid on using NULL instead of Html_tag_close_default.
Ok.
- There's a comment on *open and *close() function being always called but there's still a conditional close on display_none. Please check it.
Ok.
- Please don't merge the IPPROTO_TCP patch with it.
If you mean the TCP_NODELAY stuff, it's in the main repo already. Normally the TCP stack waits a little until there is enough data to send. This is good for throughput but bad for response time. It is especially bad for client server stuff like DPI over local loopback. It really slows down pages with cookies. But I can back it out if you like. It would no longer be necessary when we switch back to UNIX domain sockets anyway. Cheers, Johannes