On Wed, Feb 24, 2010 at 02:47:26PM -0500, Dennis Nezic wrote:
On Wed, 24 Feb 2010 14:22:01 -0300, Jorge Arellano Cid wrote:
On Wed, Feb 24, 2010 at 10:24:02AM -0500, Dennis Nezic wrote:
When dillorc's fullwindow_start=YES (which is supposed to hide the widget panels on startup), it doesn't actually do this. (It does hide it after you click on a link or type in a url.) My guess is it was assumed that the first thing you want to do when opening a browser is to type in a url (or click a bookmark link, etc) -- but this is not true. (Many times I want to simply load a single page and then close it.)
It's a bug!
Please check how the patch in current repository works for you.
Works great! Thanks!
I see an issue with the current fix. It never focusses location in fullscreen mode for new windows. So when opening a new empty window (e.g. Ctrl-N) in fullscreen mode, the location bar is not focussed. Jorge, what do you think about the alternative fix below. It sticks to the principle stated in the comment in UIcmd_open_url_nbw(). diff -r 5d2db34381f9 src/uicmd.cc --- a/src/uicmd.cc Thu Feb 25 18:17:48 2010 +0100 +++ b/src/uicmd.cc Thu Feb 25 18:22:21 2010 +0100 @@ -471,8 +471,7 @@ win->callback(win_cb, DilloTabs); - if (new_ui->get_panelmode() != UI_HIDDEN) - new_ui->focus_location(); + new_ui->focus_location(); return new_bw; } @@ -617,6 +616,8 @@ void a_UIcmd_open_url(BrowserWindow *bw, const DilloUrl *url) { a_Nav_push(bw, url); + if (BW2UI(bw)->get_panelmode() == UI_TEMPORARILY_SHOW_PANELS) + BW2UI(bw)->set_panelmode(UI_HIDDEN); a_UIcmd_focus_main_area(bw); } Cheers, Johannes