On Tue, Apr 06, 2010 at 02:41:50AM +0000, corvid wrote:
Jorge wrote:
On Fri, Apr 02, 2010 at 07:07:50PM +0000, corvid wrote:
I'd only suggest considering whether adding a URL flag (e.g. URL_FilterOut) provides more flexibility/clarity without having to add the 'requester' parameter to the API.
Can you elaborate a bit on how/where the flag would be set, and how it would help?
I haven't looked at it in enough depth to offer a good alternative yet. Just noticed of the API changes, made an extra couple of passes above the code considering the flag or having referer in the DilloUrl struct.
The idea is to commit it and to consider the alternatives later.
All right, then. Committed.
Everyone: 1) This will surely require various tweaks. 2) If it threatens to drive you insane in the meantime, there's a dillorc option.
While testing a bit more I found a problem with redirects: http://nibble.develsec.org doesn't seem to load properly when same_domain is enabled. The problem seems to be a_Nav_push(bw, bw->meta_refresh_url,a_History_get_url(NAV_TOP_UIDX(bw))); in Nav_redirection0_callback(). a_History_get_url(NAV_TOP_UIDX(bw)) is not necessarily the proper requester. Things seem to work in this example with a_Nav_push(bw, bw->meta_refresh_url,bw->nav_expect_url); but I guess bw->nav_expect_url is also not always set properly.