On Mon, Oct 20, Frank de Lange wrote:
Sebastian Geerken wrote:
- Fixed a bug in focus.c: Now, spaces are also drawn, between the words of a multi-word link. Somewhere, it is documented, that you have to highlight up to strlen(word->content.data.text) + 1, to highlight also the space.
Hmmm... that was intentional, so that focused links could be recognized more easily...
You should have commented in the code :-)
Same for the next one by the way. Anyway, it would be even better if the focus could be drawn in another pattern or color, so that it is visible even when overlayed with a selection or found highlight.
[other posting]
{Have you thought about | Is there} a way to highlight text using a pattern (like the 'gray-out' highlight for images)? I have explicitly not used a line-stile highlight for keyboard focus, because this makes it often hard to see where focus is. Links are sometimes small, no more than a '*' or a subscripted number. A line-style highlight is hard to see in those cases... I do agree that it is necessary to use a different highlight style for focus, search and selection, but the traditional focus highlight ((dotted/dashed) line around word) is not very useful in many cases. This goes even more for people with bad eyesight.
I would at least leave the traditional line, for reasons of consistence. Perhaps the link may be also highlighted, in a lighter color than the background color (and lightgray for white etc., look at Dw_style_color_create, which is used for shaded colors for borders)? This would make it unconfusable with text selections. [first posting]
Btw, apart from looking only fleetingly at it, did you try keyboard navigation? If so, any remarks about the functionality itself?
I like it, it's, aside from some glitches, quite what I meant with "geometrical navigation". The standard keys are worth to discuss, e.g. Alt-Tab is used by many window managers, and generally, I expect key combinations with the Alt modifier more at the level of windows. (IMO, no modifiers should be used for link navigation, conflicts with other functions have to be resolved somehow.) Sebastian