Paul Pelzl wrote:
On Tue, Nov 11, 2003 at 02:58:43PM +0100, Frank de Lange wrote:
[ LIST: please give keyboard navigation, on either version of the patch, a workout. This needs some testing if it is to be part of mainstream Dillo. Try it in frame sites, try navigatin between frames with Tab/Shift-Tab, try the keyboard bindings, etc. ]
With tab/frame/keynav patch v14, I've been able to get segfaults pretty easily just by moving between links. Here are some sample sites:
http://memepool.com (there is a long link on the current page that causes problems)
Fixed, was caused by Dw_page_construct_iterator() always returning iterators with mask=DW_CONTENT_ALL. This caused links which contain breaks (<br>) to segfault. I changed Dw_page_construct_iterator() to allow the caller to set a mask.
http://notlong.com/links/ (the links in the table appear to be problematic)
I see what you mean, but this is not that easy to fix. Links are sorted on y.x order using the coordinates for the first word in the link. If you look at the table, you'll notice that 'makeashorterlink.com' starts half a line above all the other links in the table row, while 'ek.dk' starts half a line after the others. This causes those links to appear in this order: makeashorterlink (link DOWN)-> one of the links to the left of it (link DOWN)-> ek.dk I'll see if I can find a simple solution to this problem (use a median coordinate? use a coordinate range?), but I do not think this will be fixed in the next patch.
http://cruel.com (a link about halfway down the current page)
Same problem as memepool.com, fixed
http://vikings.com (one of the first links in the main frame)
Same problem as memepool.com, fixed
Also, here is an example of a site where the algorithm for determining the direction of the next link breaks down: http://linkfilter.net At the end of each post there are a set of icons which get selected in a non-intuitive order.
More or less the same problem as notlong.com, but a slighly different cause. The author of the page did not use width/height tags on one of the icon links (the Stats link), this makes Dillo render the links's alt-text half a line lower. This causes the link shuffle effect you noticed. I might be able to fix this one though by adding another focusable_allocate for images. Might be fixed in next patch. Thanks fo the feedback... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]