On Tue, Jun 10, 2008 at 07:21:35PM +0200, Johannes Hofmann wrote:
On Sat, Jun 07, 2008 at 10:16:14PM +0000, corvid wrote:
Johannes wrote:
Comments welcome! I feel a bit uncomfortable proposing a pretty drastic change like this.
Although obviously I don't know the code well, it seems like an improvement.
After thinking some more about it, I believe this is the right way to go. My initial patch had some issues though: It was complete nonsense of course to make the destructor of the derived class (FltkFont and FltkColor) virtual. It only worked because Font and Color are derived from lout::Object which already has a virtual destructor. So in fact the change does not add any additional virtual methods. I also decided to keep the interface to dillo2 as it is (the now unused layout parameter in Style::create()).
So attached is my official proposal to fix the style related segfaults that where introduced by my style caching patch.
Trying to be practical I'd say: if we don't have a comment in a week let's commit. -- Cheers Jorge.-