On Thu, Sep 25, 2008 at 08:25:12PM +0000, corvid wrote:
Johannes wrote:
somtimes the end of italic words get cut off e.g. in
<html> <body> <i><a href="foo">FUU</a>BAR</i> </body> </html>
when seen with vw_fontname="helvetica".
This is due to a change in html.cc (I think it was introduced with rev 1.36). This change sets the backgroundColor for all words which means that for each word, the bounding box get's drawn before the actual text. This obviously has a performance impact too.
I'm not sure how to get back to the original behaviour (backgroundColor == NULL for normal words) without breaking anything. Can someone please have a look?
This - reverts all of the style->backgroundColor to current_bg_color - sets backgroundColor for fltk widgets because NULL is already taken to mean standard_widget_colors - sets backgroundColor for image inputs and <button>s since they use a new Layout. - changes table_cell_style's backgroundColor at the bottom of Html_tag_open_tr() if the TR specifies one. I don't know why the original code didn't need that. Maybe it was broken.
Very nice! Thanks. I think this step would have become necessary anyway if we would try to support background images.
I wasn't feeling too sure about doing this before release, but Johannes says "currently an unnecessary XFillRectangle() command is sent to the X Server for every word" and I haven't had problems running on it so far, so it seems worthy of putting on the list for consideration.
PS How do you monitor X to get an idea of what a client might be spending too much time on?
I use xtrace (http://xtrace.alioth.debian.org/). In one window I call: xtrace In the other: export DISPLAY=:9 ./dillo-fltk Cheers, Johannes