On Sat, Sep 06, 2008 at 06:38:23PM +0000, corvid wrote:
Johannes wrote:
On Sat, Sep 06, 2008 at 03:53:34AM +0000, corvid wrote:
It was like dillo had treated the </div></div><p> as a <br> until that click. I see that Textblock::addParbreak() has:
/* Another break before? */ if ((word = words->getRef(words->size () - 1)) && word->content.type == core::Content::BREAK) { word->content.breakSpace = misc::max (word->content.breakSpace, space); return; }
word = addWord (0, 0, 0, style); word->content.type = core::Content::BREAK; word->content.breakSpace = space; wordWrap (words->size () - 1);
For the sake of experiment, I stuck a wordWrap (words->size () - 1); before the return, and now it seems to work. I imagine it must have to do with lastLine->breakSpace getting updated...
Yes, it seems so. Can you please test attached patch? It just updates lastLine->breakSpace instead of calling Textblock::wordWrap, because of the comment above Textblock::wordWrap...
It also fixes some bugs in the redraw optimization. At least the <ol> issue (google.com) no longer happens here.
It appears to be working well. Thanks!
Johannes: Should I commit this patch? -- Cheers Jorge.-