On Fri, Sep 19, 2008 at 03:05:17PM +0000, corvid wrote:
Johannes wrote:
somtimes the end of italic words get cut off e.g. in
<html> <body> <i><a href="foo">FUU</a>BAR</i> </body> </html>
when seen with vw_fontname="helvetica".
This is due to a change in html.cc (I think it was introduced with rev 1.36). This change sets the backgroundColor for all words which means that for each word, the bounding box get's drawn before the actual text. This obviously has a performance impact too.
I'm not sure how to get back to the original behaviour (backgroundColor == NULL for normal words) without breaking anything. Can someone please have a look?
I've had the idea lately (not yet explored) that maybe I could rip out all of my backgroundColor setting and get the background color for the fltk widgets if it should turn out that getEmbed()->getBgColor() has what I want. I'll dig into it.
PS Is this the same reason that the tops of bold 5's are thin and the right edge of fixed-width %'s are cut off (using DejaVu fonts, at least)?
Not sure. But you can easily check by completely disabling word backgrounds as in attached patch. Cheers, Johannes