Hi, On Fri, Nov 16, 2007 at 04:22:01AM +0000, place wrote:
I'm not much of a drawing/gui person, but it's hard not being able to search pages, so I gave it a try (attached).
Good, I'm giving it a review.
- If you hit ^Q on this window or the page source or page bugs windows, dillo will crash because it assumes it's closing a bw.
Fixed in CVS. Funny how Ctrl+n from a search window produced a small dialog-sized bw!
- I didn't want a title bar, and I didn't want it to be able to outlive its bw, but I didn't know what to do about it.
- If searching scrolls the window, highlighting isn't undone properly. (If you search for something like "a", the last instance on each line will remain highlighted)
*plays with it a bit more*
Maybe it's good to have a title bar after all. It's easier to move out of the way than the 0.8.x one was...
Checking patch now... -- Cheers Jorge.-