Hi, On Thu, May 08, 2008 at 09:25:59PM +0000, corvid wrote:
Jorge wrote:
[Johannes wrote:] I noticed one regression with the new anchor code: The "Continue Reading Older Posts" link on www.boingboing.net (e.g. http://www.boingboing.net/2008/04/03/#entry-44240) no longer scrolls to the right position.
There were mixed issues here.
I just committed a patch that modifies/fixes anchor handling with repush (on the last weeks anchors didn't work for me even inside the bookmarks page).
Now it works, and more like Firefox. This is, now reloading a page with fragment, scrolls to the fragment position, but going back and forward remembers the last user-scrolled position; quite comfortable.
The page you mention, works OK when it's a local file, but not from the network. This looks like a bug hiding in the offset calculation or scroll adjustment while the page loads images.
In brief: with the patch the situation improves a lot, and there's still a bug to fix.
Things seem flaky now with redirection.
Here's what happens if I 1 type in dillo.org 2 type in minix3.org
$ dillo dillo_dns_init: Here we go! (threaded) Disabling cookies. Nav_open_url: new url='about:blank' Nav_open_url: new url='http://dillo.org' Dns_server [0]: dillo.org is 0x8171648 Connecting to 134.102.206.165 Nav_open_url: new url='http://www.dillo.org/' Dns_server [0]: www.dillo.org is 0x8194228 Connecting to 134.102.206.165 META Content-Type changes charset to: iso-8859-1 Nav_open_url: new url='http://www.dillo.org/' META Content-Type gave charset as: iso-8859-1 a_Nav_expect_done: repush! Nav_open_url: new url='http://minix3.org' Dns_server [0]: minix3.org is 0x8147220 Connecting to 130.37.20.20 Nav_open_url: new url='http://www.minix3.org/' Dns_server [0]: www.minix3.org is 0x8198090 Connecting to 130.37.20.20 a_Nav_expect_done: e2ereload! META Content-Type changes charset to: iso-8859-1 Nav_open_url: new url='http://www.dillo.org/' META Content-Type gave charset as: iso-8859-1 a_Nav_expect_done: repush!
I did not press Back.
Oh yes. I didn't want to dig deep into it, but after this there was no chance to hide. :) There was a semantic confussion with the E2EReload flag, which was split into URL_E2EQuery and URL_ReloadPage. Now we can tell the difference between an first-time E2EQuery and an E2E reload. Patch committed. There's still a bug hiding, most probably inside the code setting the scroll position in dw2. When you have a page with repush (i.e. with charset specified in META element, e.g. www.dillo.org :), and you scroll the page, and then reload. It will be shown from the origin, even though a_UIcmd_set_scroll_xy is called from nav.c:321 with the right coords (enable the _MSG to check). -- Cheers Jorge.-