On Fri, Sep 26, 2008 at 07:36:30PM +0200, Johannes Hofmann wrote:
On Mon, Sep 22, 2008 at 03:31:58PM +0000, corvid wrote:
Johannes wrote:
On Mon, Sep 22, 2008 at 05:06:35AM +0000, corvid wrote:
I wrote:
Johannes wrote:
On Fri, Sep 19, 2008 at 03:21:58PM +0000, corvid wrote: > I wrote: > > Sometimes the window closes when I click on a page. > > A quick fprintf() says PUSH causing a recursive FOCUS_CHANGE, > > and then HIDE. > > (I only had one tab, in case that matters.) > > Okay, that was not accurate. > It looks like PUSH and FOCUS_CHANGE is from clicking > and HIDE is from pressing Space to page down.
I'm also seeing that. No idea yet...
I finally sat down and worked out what the problem is. It's not only click-space, but that's the most common case.
<title>...&[character]...</title>
causes click-[character] to close it.
So fltk must think that's a shortcut in the tab text, and it tries to do whatever it does with shortcuts -- but there's a shortcut-handling piece missing, so it just closes the window.
It doesn't care about the tab text. It's the UI->window() label stuff that's causing the problem. It appears that you can escape &-as-shortcut in general by doubling them, but I end up with doubled && in the title bar. Why wasn't this a problem in the past? I don't know; maybe it _was_ regarded as a shortcut but handle() took care of it.
Thanks for tracking this down! I could also reproduce it with pre-tabs versions.
I have a dillo from Sept. 5 around, and space doesn't close the window for me.
Please try attached patch.
It works! RAW_LABEL is so much better than trying to escape &.
Here comes a complete patch to disable label parsing for labels set from html. I hope I didn't miss one.
Committed. -- Cheers Jorge.-