Johannes wrote:
On Thu, Dec 17, 2009 at 12:37:36AM +0000, corvid wrote:
Johannes wrote:
On Tue, Dec 15, 2009 at 06:58:28PM +0000, corvid wrote:
Johannes wrote:
On Tue, Dec 15, 2009 at 09:24:58PM +0900, furaisanjin wrote:
2009/12/15 Johannes Hofmann <Johannes.Hofmann@gmx.de>: > Any opinions? Does this solve the problem?
Could you consider this patch? This solves both problems I reported.
Looks good to me. Is this ok for all? If there are no complaints I would commit a slightly modified version (attached).
I think I like having Location lose focus after I press enter.
but the patch I had proposed originally doesn't seem to fix all of furaisanjin's issues. E.g. when starting dillo with an URL on the commandline, the location bar will have the focus.
Are there cases where my furaisanjin's patch causes unexpected switches of focus, i.e. not triggered directly by a user action?
I've completely lost track of what various versions do; I'm just saying that typing in an address, pressing enter, and having focus switch from Location to Main is nice.
Ah ok. I just committed furaisanjin's patch with a minor change. I there should be unexpected focus switches please report them, so we can look it this again.
Oh, I see the confusion now. I must have misapplied that last version somehow, because it wasn't changing focus for me, but now using that same patch from tip seems to be working fine. Sorry about that.