On Thu, Jan 22, 2009 at 11:06:01PM +0900, furaisanjin wrote:
2009/1/22 furaisanjin <furaisanjin@gmail.com>:
By the way I notice bookmark (ctrl-b) doesn't work. Does anybody has this problem?
bookmark problem is solved by this patch.
--- a/src/cache.c Thu Jan 22 08:31:44 2009 -0300 +++ b/src/cache.c Thu Jan 22 23:03:33 2009 +0900 @@ -512,8 +512,10 @@ if (entry->CharsetDecoder) a_Decode_free(entry->CharsetDecoder); a_Misc_parse_content_type(ctype, NULL, NULL, &charset); - entry->CharsetDecoder = a_Decode_charset_init(charset); - dFree(charset); + if (charset) { + entry->CharsetDecoder = a_Decode_charset_init(charset); + dFree(charset); + } curr = Cache_current_content_type(entry);
/* Invalidate UTF8Data */
Have you added charset to the content-type given by the bookmarks dpi? or have you added a META or both? I would like to know the problem in detail, because it looks like adding an extra parameter to a_Cache_set_content_type() would make its API, and code cleaner. e.g. ({CA_Header|CA_Meta} as last parameter). If the problem can be solved with that API change, great, hence the above question. BTW AFAIS, with the above patch if CharsetDecoder was already set, and a_Misc_parse_content_type() fails, CharsetDecoder is left in an unknown state. -- Cheers Jorge.-