Hi Jeremy, On Tue, Sep 22, 2009 at 07:47:09AM +0100, Jeremy Henty wrote:
On Mon, Sep 21, 2009 at 11:58:09PM -0400, Jorge Arellano Cid wrote:
* The HTML parser in table.cc does not create table widgets if USE_TABLES is not defined. Perhaps this code should do the same?
Not necessary. That was an old feature for narrow displays.
In that case, shouldn't we remove USE_TABLES entirely?
* It would be nice if the widgets and the redirect link were styled from the User Agent style in css.cc . ...
AFAIS, the warning widget needs its own scheme, like the rest of the panel.
Perhaps we could extend the default style in css.cc with clauses like "dillo meta-refresh-warning redirect { color: ... }", using "dillo" as a reserved CSS class for internal use? Then all of the style information would be in CSS and none of it would be hard-coded in the parser, which is how it should be.
Yes, this would be possible. Other browsers also have similar extensions. They seem to start with a '-' usually ("-webkit...", "-moz..."). But generally if we generate messages in the rendering area, we can't avoid that someone fakes them on his webpage.
I still haven't worked out how to apply the CSS stylesheets to the widgets I create (the style engine mechanism isn't being applied because I create the widgets directly instead of from HTML). I tried adding calls to styleEngine->{startElement,endElement}() but nothing happened. I'm clearly still missing something. I'll have another look, but any tips will be welcome!
That should work. You need those styleEngine->{startElement,endElement}() calls and then use styleEngine->style() for your widgets. See plain.cc for an example. And of course you need to specify corresponding css either in the user agent style in css.cc or for testing just in your ~/.dillo/style.css file. Regards, Johannes