7 Feb
2009
7 Feb
'09
8:03 p.m.
On Sat, Feb 07, 2009 at 05:57:21PM +0000, Jeremy Henty wrote:
There is IMHO a nasty code smell around a_Html_add_new_image(): it takes a boolean parameter that determines whether or not it actually adds the image. It's only called from two other places, once with the parameter set to false and once with it set to true.
This patch cleans things up by renaming a_Html_add_new_image() to a_Html_image_new(), removing the boolean parameter and making the caller add the image (or not) as appropriate.
Perhaps it is a judgement call as to whether this is an improvement, but I feel that it is. Please comment.
did you forget to attach the patch? Cheers, Johannes