On Thu, Jan 22, 2009 at 08:34:32AM -0300, Jorge Arellano Cid wrote:
On Thu, Jan 22, 2009 at 10:22:39AM +0100, Hofmann Johannes wrote:
Hi,
On Wed, Jan 21, 2009 at 07:06:06PM -0300, Jorge Arellano Cid wrote:
On Wed, Jan 21, 2009 at 08:29:34PM +0900, furaisanjin wrote:
Hi.
This is work around.
This so called "work around" works very well.
While working on this, I used the testcases in the following table:
load Reload Back ---------------------------- H__ OK OK OK H = has charset in HTTP header HM_ OK OK OK M = has charset in META H_C OK OK OK C = has remote CSS stylesheet HMC OK OK OK _ = disabled ___ OK OK OK _M_ OK OK OK __C OK OK OK _MC OK OK OK ----------------------------
Both patches pass all of them!
I committed a similar approach that has a single code path for calling a_Decode_charset_init().
Please test and comment.
Starting with revision d29cdb5b842e I get repeatable crashes when clicking on the "Home" link in about:splash.
Please try the current tip.
I noticed one more issue, still present in tip. On http://amazon.de dillo crashes with: Program terminated with signal 11, Segmentation fault. b#0 0x08069f2e in Html_write_raw (html=0x2866f500, buf=0x2874303d <Address 0x2874303d out of bounds>, bufsize=33743, Eof=0) at html.cc:3398 3398 if (*start == '/' || /* </x> */ (gdb) bt #0 0x08069f2e in Html_write_raw (html=0x2866f500, buf=0x2874303d <Address 0x2874303d out of bounds>, bufsize=33743, Eof=0) at html.cc:3398 #1 0x0806a53a in DilloHtml::write (this=0x2866f500, Buf=0x28743000 <Address 0x28743000 out of bounds>, BufSize=675537188, Eof=0) at html.cc:577 #2 0x0806a58e in Html_callback (Op=0, Client=0x2862ea40) at html.cc:3564 #3 0x0805a706 in Cache_process_queue (entry=0x28653700) at cache.c:1143 #4 0x08058288 in a_Chain_fcb (Op=675537188, Info=0x1, Data1=0x286b8210, Data2=0x80f573c) at chain.c:112 #5 0x0807899c in a_Dpi_ccc (Op=2, Branch=2, Dir=1, Info=0x2862e400, Data1=0x286b8c20, Data2=0x0) at dpi.c:219 #6 0x08058288 in a_Chain_fcb (Op=675537188, Info=0x1, Data1=0x286b8c20, Data2=0x0) at chain.c:112 #7 0x08079311 in a_IO_ccc (Op=2, Branch=2, Dir=1, Info=0x2862ee20, Data1=0x2862e4a0, Data2=0x0) at IO.c:414 #8 0x0807949e in IO_callback (io=0x2862e4a0) at IO.c:201 #9 0x0807956f in IO_fd_read_cb (fd=4, data=0x4) at IO.c:287 #10 0x080c9fd5 in fltk::wait () #11 0x080ca185 in fltk::run () #12 0x0804f03a in main (argc=2, argv=0xbfbff850) at dillo.cc:334 Cheers, Johannes