Hi, On Wed, Jan 21, 2009 at 07:06:06PM -0300, Jorge Arellano Cid wrote:
On Wed, Jan 21, 2009 at 08:29:34PM +0900, furaisanjin wrote:
Hi.
This is work around.
This so called "work around" works very well.
While working on this, I used the testcases in the following table:
load Reload Back ---------------------------- H__ OK OK OK H = has charset in HTTP header HM_ OK OK OK M = has charset in META H_C OK OK OK C = has remote CSS stylesheet HMC OK OK OK _ = disabled ___ OK OK OK _M_ OK OK OK __C OK OK OK _MC OK OK OK ----------------------------
Both patches pass all of them!
I committed a similar approach that has a single code path for calling a_Decode_charset_init().
Please test and comment.
Starting with revision d29cdb5b842e I get repeatable crashes when clicking on the "Home" link in about:splash. Cheers, Johannes Program received signal SIGBUS, Bus error. DilloHtml::getCurTagLineNumber (this=0x28778500) at html.cc:596 596 if (p[i] == '\n') (gdb) bt #0 DilloHtml::getCurTagLineNumber (this=0x28778500) at html.cc:596 #1 0x08063e38 in DilloHtml::bugMessage (this=0x28778500, format=0x80f8198 "HEAD section lacks the TITLE element\n") at html.cc:149 #2 0x08063f2a in Html_tag_close_head (html=0x28778500, TagIdx=32) at html.cc:1569 #3 0x080684de in Html_tag_cleanup_at_close (html=0x28778500, TagIdx=32) at html.cc:1306 #4 0x08068957 in DilloHtml::finishParsing (this=0x28778500, ClientKey=2) at html.cc:627 #5 0x0805a566 in Cache_process_queue (entry=0x287418c0) at cache.c:1153 #6 0x0805b378 in a_Cache_process_dbuf (Op=2, buf=0x0, buf_size=0, Url=0x28741c80) at cache.c:886 #7 0x0805c871 in a_Capi_ccc (Op=4, Branch=2, Dir=1, Info=0x2874fd60, Data1=0x0, Data2=0x0) at capi.c:618 #8 0x08058288 in a_Chain_fcb (Op=0, Info=0x287a3000, Data1=0x0, Data2=0x0) at chain.c:112 #9 0x08078cee in a_Dpi_ccc (Op=4, Branch=2, Dir=1, Info=0x2874f140, Data1=0x0, Data2=0x0) at dpi.c:671 #10 0x08058288 in a_Chain_fcb (Op=0, Info=0x287a3000, Data1=0x0, Data2=0x0) at chain.c:112 #11 0x0807969e in a_IO_ccc (Op=4, Branch=2, Dir=1, Info=0x2874f6c0, Data1=0x2874f8c0, Data2=0x0) ---Type <return> to continue, or q <return> to quit--- ---Type <return> to continue, or q <return> to quit--- at IO.c:418 #12 0x08079980 in IO_callback (io=0x2874f8c0) at IO.c:211 #13 0x080799ff in IO_fd_read_cb (fd=7, data=0x2) at IO.c:287 #14 0x080ca465 in fltk::wait () #15 0x080ca615 in fltk::run () #16 0x0804f03a in main (argc=1, argv=0xbfbff864) at dillo.cc:334 (gdb)