Hi, On Tue, Aug 06, 2024 at 01:27:38PM +0200, Rodrigo Arias wrote:
Hi,
On Tue, Aug 06, 2024 at 01:14:26PM +0200, a1ex@dismail.de wrote:
Thanks!, so far it seems to be working fine.
I'll try to get it merged soon.
Just wanted to check if there is anything else that needs to be addressed with this patch. If so, please let me know and I will work on it.
I think it is good as-is, I just need to test it for a bit. I'll try to merge it once I finish with other changes I'm working on. It is queued for 3.2.0:
I'm working on a zoom icon that a bit more similar to the other icons, but I'm having problems to avoid aliasing in the border due to the limitations of XPM with the alpha transparency. I attach two screenshots, one (zoom.png) with the icon background set to the same color of the menu so the alpha is blended properly (but the icon is not transparent). And another one (zoom-alias.png) with the alpha cutoff at half, so alpha values less than 127 are converted to transparent pixels. This one shows some aliasing in the borders, but it works fine if you change the menu color. Not sure if there is a good solution to this problem, other than manually making the aliasing work well with a sharp border. The other icons cleverly avoid this problem by doing rectangular shapes. I'm also considering leaving the save button by default for now, and moving the zoom button to the right, so we preserve the "muscle memory" of users. I need to play a bit more to see how it "feels". Best, Rodrigo.
