Hi Jorge, On Thu, Sep 25, 2008 at 06:51:14PM -0400, Jorge Arellano Cid wrote:
Hi there,
On Mon, Sep 22, 2008 at 10:03:32AM -0700, bf wrote:
--- On Mon, 9/22/08, corvid <corvid@lavabit.com> wrote:
On Mon, Sep 22, 2008 at 12:06:27AM +0000, corvid wrote:
Jeremy wrote:
This patch is more of a call for discussion than a fix as it fiddles with the UI. It makes Dillo select the new tab after creating it. As a special case, middle-clicking a link does not select the new tab unless the Shift key is down. (This is the same behaviour as Firefox which saves learning a new set of reflexes.) What do people think?
It does seem that "I want to see this in a new tab/window now" has been more common for me than "I want to look at this in a different tab/window later".
So do you think that a middle button click on a
select the new tab? I often go down a list opening up new tabs to look at later so I get frustrated when I have to switch back each time. On the other hand when I create a new blank tab I always want to switch to it immediately so I prefer Dillo to do
From: corvid <corvid@lavabit.com> Subject: Re: [Dillo-dev] PATCH: select new tabs To: dillo-dev@dillo.org Date: Monday, September 22, 2008, 11:41 AM Jeremy wrote: link should always that for me.
Well, I've never been in the habit of using tabs, so I don't have too much of an opinion about the particulars yet. I will agree that allowing both "see this now" and "see this later" in some way is good.
Yes, please make it possible for users to choose both via keyboard or mouse -- I find it very useful to alternate between both behaviors -- sometimes I want to switch immediately to new content in a new tab, and other times I want to open a new tab, but remain in the current tab, and look at the new tab "in a minute". You don't want to have to either backtrack in a webpage or navigate back to a tab unnecessarily. Some other glitches(?) I've noticed: [...]
Considering the feedback, there's a new patch in CVS.
It adds: "New Tab Ctrl+T" in the File menu "Open Link in new Tab" in the Link menu "Open Image in new Tab" in the Image menu
It also adds two dillo2rc options: (don't forget to add them to your local dillo2rc)
# A mouse's middle click over a link opens a new Tab. # If you prefer to open a new Window instead, set it to NO. #middle_click_opens_new_tab=YES
# Focus follows new Tabs. # You can hold SHIFT to temporarily revert this behaviour. #focus_new_tab=YES
Note that Ctrl+T always focus the new Tab, but you can use SHIFT while clicking to revert the focus_new_tab setting!
It also adds Johannes fixup for the resizable in case we just removed it.
Please give it some test and enjoy! :-)
Excellent! I like how you avoided to make DilloTabs a member of BrowserWindow. Cheers, Johannes