?? wrote:
After update, the dillo crash while opening http://www.google.com.tw on dlib/dlib.c:173
The array haystack is null and unchecked cause the problem...
Log as below
gigijoe@user-desktop:~/dillo2$ gdb src/dillo GNU gdb 6.8-debian Copyright (C) 2008 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "i486-linux-gnu"... (gdb) r Starting program: /home/gigijoe/dillo2/src/dillo [Thread debugging using libthread_db enabled] paths: Cannot open file '/home/gigijoe/.dillo/keysrc' paths: Cannot open file '/usr/local/etc/dillo/keysrc' paths: Using internal defaults... dillo_dns_init: Here we go! (threaded) Disabling cookies. Nav_open_url: new url='http://www.google.com.tw' [New Thread 0xb795b8e0 (LWP 11430)] [New Thread 0xb782bb90 (LWP 11433)] Dns_server [0]: www.google.com.tw is 74.125.19.105 74.125.19.106 74.125.19.99 74.125.19.104 74.125.19.103 74.125.19.147 [Thread 0xb782bb90 (LWP 11433) exited] Connecting to 74.125.19.105
Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0xb795b8e0 (LWP 11430)] 0x0807ee7c in dStristr (haystack=0x0, needle=0x810c13f "javascript") at dlib.c:173 173 for (i = 0, j = 0; haystack[i] && needle[j]; ++i) Current language: auto; currently c (gdb) q The program is running. Exit anyway? (y or n) y
I believe it's breaking in your javascript patch. We usually write if (attrbuf) { .. } But regardless, dStristr() should have checks for NULL. I'll add them in a moment.