On Fri, Oct 15, 2010 at 10:30:01AM +0200, Johannes Hofmann wrote:
Hi Jeremy,
On Thu, Oct 14, 2010 at 07:16:15PM +0100, Jeremy Henty wrote:
This small bit of HTML (attached) renders with an enormous vertical extent in Dillo - I have to hold down the mouse in the lower half of the scrollbar for several seconds before the slider moves even one pixel! Strangely, if you take out the "<span>"s then the vertical extent is *much* smaller, although still far too large. What's going on?
Thanks for the nice test case. valgrind shows, that an uninitialized value is used somewhere. The problem seems quite tricky: A value of 'auto' is not allowed for line-height ('normal' would be correct), but dillo does not ignore the declaration as it should. Attached is a slightly modified test case, that shows the issue. There are two competing declarations for line-height and normally the last should win, but if it is illegal, the first should be used. firefox does that correctly and shows the illegal declaration in the error console. I will try to fix it.
I just pushed a fix for the use of uninitialized values issue. That fixes your testcase, but the modified one below is still broken. Cheers, Johannes
Cheers, Johannes
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html> <head> <title></title> <style type="text/css" > li {line-height: 10em;} li {line-height: auto;} </style> </head> <body> Begin <ul> <li><span>AAAAAAAAAA</span></li> <li><span>AAAAAAAAAA</span></li> <li><span>AAAAAAAAAA</span></li> <li><span>AAAAAAAAAA</span></li> <li><span>AAAAAAAAAA</span></li> </ul> End </body> </html>