On Sun, Mar 02, 2008 at 09:23:53PM +0100, Johannes Hofmann wrote:
On Sun, Mar 02, 2008 at 03:45:09PM +0000, Jeremy Henty wrote:
On Sun, Mar 02, 2008 at 04:14:00PM +0100, Johannes Hofmann wrote:
I think your proposed fix is fine. It's just that I don't like the wrapper methods too much in the first place and now we need even more code to support it...
I'm not particularly attached to my proposed fix, my real concern is being valgrind clean because anything that makes valgrind harder to use is bad news. My patch was just the simplest way I could see to achieve that. If there's a better way to do it then that's great!
ok, here is my proposal. It reduces the additional code in table.cc a bit. Thanks to Jeremy for testing with valgrind.
OK, committed. Please beware that this may cloak bugs. It was due to an assertion from the old code that the Table::draw() bug was found: http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-March/003837.html
Thanks to Jeremy for testing with valgrind.
Ditto. -- Cheers Jorge.-