On Thu, Oct 21, 2010 at 11:01:42AM -0300, Jorge Arellano Cid wrote:
On Thu, Oct 21, 2010 at 02:49:00PM +0200, Johannes Hofmann wrote:
[...]
Note4: Considering the extensive use of "html->styleEngine", I'd use something similar to HT2TB, S_TOP macros. This is: SE(html) <=> html->styleEngine SE(html)->setNonCssHint <=> html->styleEngine->setNonCssHint I can quickly make a patch if you agree.
Yes, sure. Maybe an inlined method in DilloHtml like
DilloHtml::setNonCssHint(...) { styleEngine->setNonCssHint(...); }
would result in even shorter lines:
html->setNonCssHint(...)
DISCLAIMER: I'm by no mean a C++ guru!
gcc says:
html_common.hh:213: error: invalid use of incomplete type 'struct StyleEngine'
Bleh, that's what you get if you play tricks and make circular depending includes (as I did with styleengine.hh).
AFAIU, the original setNonCssHint is also inlined, and it uses the private "struct Node", which upon expansion is not defined.
That shouldn't be a problem, inlining is not done by the preprocessor.
I'd go with "SE(html)" ;-)
Let me first try whether I can disentangle the includes. If that doesn't work we can use the macro. Cheers, Johannes