Hi Jeremy, On Sat, Dec 22, 2007 at 02:10:32AM +0000, Jeremy Henty wrote:
This patch initialises FltkViewport::{scrollDX,scrollDY}. This removes a valgrind warning about a conditional jump depending on uninitialised data. It also fixes the mysterious sporadic disappearing page bug that was afflicting the development of the TextEditor patch. This makes me very happy, and confirms yet again that valgrind is awesome!
Excellent! scrollDX, scrollDY were introduced by one of my scrolling patches btw.... I also know now why I could no longer reproduce the problem: To debug the problem I had used some MALLOC_OPTIONS that cause malloced data to be initialized with some weird pattern. With this option I could reproduce the failure. Later I forgot to set the option and the problem seemed to be gone. And I can only agree that valgrind is a awesome tool. It helped a lot with the style reference bug too. I would still suggest to use my latest patch that calls layout() of child widgets from FltkWidgetView. Can you make a combined patch for Jorge? Regards, Johannes
Regards,
Jeremy Henty
diff -pru -- dw2-ref/dw/fltkviewport.cc dw2-cur/dw/fltkviewport.cc --- dw2-ref/dw/fltkviewport.cc 2007-12-22 01:23:39.000000000 +0000 +++ dw2-cur/dw/fltkviewport.cc 2007-12-22 01:46:11.000000000 +0000 @@ -46,7 +46,7 @@ FltkViewport::FltkViewport (int x, int y vscrollbar->set_vertical(); vscrollbar->callback (vscrollbarCallback, this);
- scrollX = scrollY = 0; + scrollX = scrollY = scrollDX = scrollDY = 0; dragScrolling = 0;
gadgetOrientation[0] = GADGET_HORIZONTAL;
_______________________________________________ Dillo-dev mailing list Dillo-dev@dillo.org http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev