18 Jul
2010
18 Jul
'10
11:40 a.m.
OK, the problem with VPATH builds is fixed but I think it can be improved. Firstly, because -I is a preprocessor directive, it should be added to AM_CPP_FLAGS. Secondly, the Makefile uses .. in various places to navigate from the current build directory to where various headers and libraries are. I think it is better to locate other directories from the top of the build and source trees. So I would prefer to use -I$(top_srcdir) instead of -I$(srcdir)/.. , and $(top_builddir)/path/to/lib instead of ../path/to/lib . Patches attached, tested as before with in-source and external builds. Regards, Jeremy Henty