On Tue, May 27, 2008 at 02:18:29PM -0400, Jorge Arellano Cid wrote:
On Tue, May 27, 2008 at 05:03:13PM +0100, Jeremy Henty wrote:
The patch is in two parts: the first makes the changes and the second moves the new methods to the right place in the file. If I roll the changes and the move into one then "diff" gets confused and creates an unreadable monster of a patch.
[...] BTW, here diff made a nice single patch.
I might have messed up the cut and paste on the first attempt and moved more code than I intended, which is why I got the monster diff. However I think that splitting up the patch into a change diff and a move diff might be better for reviewers as it gives them a diff that shows exactly what has changed rather than forcing them to manually compare a delete chunk in one place with an add chunk elsewhere. So I might continue splitting up diffs this way, unless you and the other reviewers think it just makes more work.
BUG: Please notice that forms "reset" doesn't reset selection lists. (it also wasn't working before the patch).
to_do_list++; Regards, Jeremy Henty