Hi, On Sun, Jun 10, 2012 at 10:39:21PM +0400, 123 wrote:
I have split patch into three patches.
Good!
geometry.diff fixes --geometry flag
Fixed --geometry flag. It is --geometry in man page but -geometry in usage and only -geometry is recognized by program.
I'm not sure here. -geometry seems to be somewhat standard [1] and I don't want to break people's scripts etc without very good reason. So for now I adjusted the man page.
getcmdoption.diff simplifies getCmdOption
Simplified getCmdOption. Removed State enum, it was overkill. It is also possible to remove support for mandatory arguments (opt_argc < 0) as it is not used, but it does not add LOC so I left it there.
Hm, if the patch would fix some bug - even some minor stuff - I would commit it together with the cleanup, but not just for the reduced LOC. Any other takers?
aboutblank.diff removes unnecessary check.
Removed check for about:blank as start_page, it is not a special case.
Committed.
Minor fixes (#include order, indentation) are not included.
Good. Cheers, Johannes [1] http://www.progsoc.org/tfm/tfm97/node32.html